feat: added authorizeWithSeed to the vote program in web3.js
#27627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore the first commit; you can go and approve it in #27624. |
steveluscher
commented
Sep 6, 2022
| @@ -152,6 +171,9 @@ export function getAlloc(type: any, fields: any): number { | |||
| if (Array.isArray(field)) { | |||
| return field.length * getItemAlloc(item.elementLayout); | |||
| } | |||
| } else if ('fields' in item) { | |||
There was a problem hiding this comment.
Go review this in #27624.
Codecov Report
@@ Coverage Diff @@
## master #27627 +/- ##
=========================================
- Coverage 76.9% 76.8% -0.1%
=========================================
Files 48 52 +4
Lines 2505 2671 +166
Branches 355 367 +12
=========================================
+ Hits 1927 2053 +126
- Misses 448 485 +37
- Partials 130 133 +3 |
This was referenced Oct 1, 2022
This was referenced Oct 11, 2022
This was referenced Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Read all about what the
authorizeWithSeedinstruction is for, here. #25928.Summary of Changes
VoteProgram.authorizeWithSeedVoteProgram.authorizeWithSeedCloses #25974.