Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/ is now more reproducible locally #276

Merged
merged 7 commits into from
May 29, 2018

Conversation

solana-grimes
Copy link
Contributor

  • ./ci/run-local.sh can be used to emulate (most of) the buildkite pipeline locally
  • ./ci/coverage.sh in a docker container, and works locally (with README.md updates)
  • ./ci/test-cuda.sh now remains the only CI step that relies on the buildkite agent it runs on

@codecov
Copy link

codecov bot commented May 29, 2018

Codecov Report

Merging #276 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   81.53%   81.45%   -0.08%     
==========================================
  Files          31       30       -1     
  Lines        3109     3058      -51     
==========================================
- Hits         2535     2491      -44     
+ Misses        574      567       -7
Impacted Files Coverage Δ
src/mint.rs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29061cf...b0b3abe. Read the comment docs.

@garious
Copy link
Contributor

garious commented May 29, 2018

Not sure if you'll find this useful, but here's a reference to the last time i tried to perfect a multi-OS Docker CI solution: https://github.com/maxk-org/hogl/blob/master/.travis.yml

@solana-grimes solana-grimes merged commit 86a50ae into solana-labs:master May 29, 2018
@solana-grimes solana-grimes deleted the ci branch May 29, 2018 05:23
willhickey pushed a commit that referenced this pull request Mar 18, 2024
…) (#276)

* vote: deprecate unused legacy vote tx plumbing (#274)

(cherry picked from commit b27c80a)

# Conflicts:
#	sdk/src/feature_set.rs

* fix conflicts

---------

Co-authored-by: Ashwin Sekar <[email protected]>
Co-authored-by: Ashwin Sekar <[email protected]>
AshwinSekar added a commit to AshwinSekar/solana that referenced this pull request Mar 19, 2024
…lana-labs#274) (solana-labs#276)

* vote: deprecate unused legacy vote tx plumbing (solana-labs#274)

(cherry picked from commit b27c80a)

# Conflicts:
#	sdk/src/feature_set.rs

* fix conflicts

---------

Co-authored-by: Ashwin Sekar <[email protected]>
Co-authored-by: Ashwin Sekar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants