chore: tee coverage test stderr #27551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
|
forget to add --nocapture. the result is like |
mergify bot
pushed a commit
that referenced
this pull request
Sep 3, 2022
* chore: tee coverage test stderr * chore: add --no-capture (cherry picked from commit 4071dc3)
mergify bot
pushed a commit
that referenced
this pull request
Sep 3, 2022
* chore: tee coverage test stderr * chore: add --no-capture (cherry picked from commit 4071dc3)
mergify bot
added a commit
that referenced
this pull request
Sep 3, 2022
chore: tee coverage test stderr (#27551) * chore: tee coverage test stderr * chore: add --no-capture (cherry picked from commit 4071dc3) Co-authored-by: Yihau Chen <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Sep 3, 2022
chore: tee coverage test stderr (#27551) * chore: tee coverage test stderr * chore: add --no-capture (cherry picked from commit 4071dc3) Co-authored-by: Yihau Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We can't read logs from a failed coverage test cuz we redirect stderr to a file. when it failed, it didn't upload the file.
This change will make this test become very noisy. It prints a lot of things due to
RUST_LOG=solana=trace.Summary of Changes
Tee target/cov/coverage-stderr.log