Use batch send in bench-tps to send transactions #27527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Use batch send in bench-tps to send transactions * serialize using par iter (cherry picked from commit 49df1c4) # Conflicts: # tpu-client/src/tpu_client.rs
mergify bot
added a commit
that referenced
this pull request
Sep 1, 2022
…27560) * Use batch send in bench-tps to send transactions (#27527) * Use batch send in bench-tps to send transactions * serialize using par iter (cherry picked from commit 49df1c4) # Conflicts: # tpu-client/src/tpu_client.rs * fix merge issues Co-authored-by: Pankaj Garg <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 10, 2022
…s#27527) (solana-labs#27560) * Use batch send in bench-tps to send transactions (solana-labs#27527) * Use batch send in bench-tps to send transactions * serialize using par iter (cherry picked from commit 49df1c4) # Conflicts: # tpu-client/src/tpu_client.rs * fix merge issues Co-authored-by: Pankaj Garg <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 13, 2022
…s#27527) (solana-labs#27560) * Use batch send in bench-tps to send transactions (solana-labs#27527) * Use batch send in bench-tps to send transactions * serialize using par iter (cherry picked from commit 49df1c4) # Conflicts: # tpu-client/src/tpu_client.rs * fix merge issues Co-authored-by: Pankaj Garg <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 13, 2022
…s#27527) (solana-labs#27560) * Use batch send in bench-tps to send transactions (solana-labs#27527) * Use batch send in bench-tps to send transactions * serialize using par iter (cherry picked from commit 49df1c4) # Conflicts: # tpu-client/src/tpu_client.rs * fix merge issues Co-authored-by: Pankaj Garg <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 13, 2022
…s#27527) (solana-labs#27560) * Use batch send in bench-tps to send transactions (solana-labs#27527) * Use batch send in bench-tps to send transactions * serialize using par iter (cherry picked from commit 49df1c4) # Conflicts: # tpu-client/src/tpu_client.rs * fix merge issues Co-authored-by: Pankaj Garg <[email protected]>
lijunwangs
pushed a commit
that referenced
this pull request
Sep 14, 2022
…27560) * Use batch send in bench-tps to send transactions (#27527) * Use batch send in bench-tps to send transactions * serialize using par iter (cherry picked from commit 49df1c4) # Conflicts: # tpu-client/src/tpu_client.rs * fix merge issues Co-authored-by: Pankaj Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
bench-tpsperformance is not great when QUIC is used for sending transactions.Summary of Changes
The client was sending individual transaction from batch one at a time, and waiting for the QUIC to finish sending it. This throttles the transaction send rate.
This PR implements a
batch_sendwrapper using the existing client APIs, and uses that that in the bench-tps client.Fixes #