Interleaved snapshot unpack versioning #27484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re account fields
apfitzge
changed the title
|
This shouldn't go out until #27192 is rolled out. |
brooksprumo
reviewed
Sep 9, 2022
| @@ -199,7 +196,7 @@ struct UnarchivedSnapshot { | |||
| #[derive(Debug)] | |||
| struct UnpackedSnapshotsDirAndVersion { | |||
| unpacked_snapshots_dir: PathBuf, | |||
| snapshot_version: String, | |||
| snapshot_version: SnapshotVersion, | |||
Comment on lines
+170
to
+171
| match snapshot_version { | ||
| SnapshotVersion::V1_2_0 => { |
apfitzge
deleted the
clean_up/interleaved_snapshot_unpack_versioning_27346
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#27346. #26590 introduced snapshot rebuilding logic that did not check version before unpacking account fields since the version file was serialized later on. We've moved the version file forward in the snapshot in #27192, so we can check the version before loading account fields.
Summary of Changes
Wait for, deserialize, and check snapshot version before processing accounts fields
Fixes #27346