Add block event logic to EntryStreamStage #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2746 +/- ##
========================================
+ Coverage 79.1% 79.2% +<.1%
========================================
Files 115 115
Lines 19203 19319 +116
========================================
+ Hits 15201 15312 +111
- Misses 4002 4007 +5 |
CriesofCarrots
force-pushed
the
stream-block-event
branch
2 times, most recently
from
99cf929 to
cd24231
Compare
CriesofCarrots
force-pushed
the
stream-block-event
branch
from
cd24231 to
fed6004
Compare
mvines
reviewed
Feb 13, 2019
Co-authored-by: Sunny Gleason <[email protected]> Co-authored-by: Tyera Eulberg <[email protected]>
CriesofCarrots
force-pushed
the
stream-block-event
branch
from
fed6004 to
09399e5
Compare
CriesofCarrots
force-pushed
the
stream-block-event
branch
from
09399e5 to
ba17616
Compare
jeffwashington
added a commit
that referenced
this pull request
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The block explorer needs to know the last entry_id of a valid block, ie. the block id, in order to display and organize by this identifier. It is currently very difficult for the service to determine the appropriate entry.
Summary of Changes
Adds Output struct and traits to EntryStream to get rid of duplication (and potential for bugs) between mock and live streams.
Adds
emit_block_eventmethod to EntryStreamImplements logic (based on current ReplayStage code) in EntryStreamStage to stream block events; this will need to be updated when forking-bank code lands.
Closes #2666 (refactor)