Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster exit for storage_stage client #2744

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

sakridge
Copy link
Member

Problem

storage_stage can take a long time to exit if there is no leader. Causes test_replay to hang for a bit because the default timeout is 30 seconds.

Summary of Changes

Change the client timeout to 5 seconds and check exit on each iteration.

Fixes #

Shorten the timeout and check for exit on every iteration
of fetching a last id.
@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #2744 into master will increase coverage by <.1%.
The diff coverage is 76.9%.

@@           Coverage Diff            @@
##           master   #2744     +/-   ##
========================================
+ Coverage    79.1%   79.1%   +<.1%     
========================================
  Files         115     115             
  Lines       19174   19204     +30     
========================================
+ Hits        15169   15195     +26     
- Misses       4005    4009      +4

@sagar-solana
Copy link
Contributor

Interesting that new_with_timeout exists. I feel like thin_client could use some refactoring to make sure all methods on thin_clients with timeouts, timeout. Now we've got some things that the rpc_client inside thin_client handles in terms of timing out and some things that fns within thin_client need to deal with (like the one I added).

@sakridge
Copy link
Member Author

@sagar-solana yes I added it for another test case where it needed to timeout in a shorter amount of time.

@sakridge sakridge merged commit 0bb6940 into solana-labs:master Feb 13, 2019
jstarry pushed a commit to jstarry/solana that referenced this pull request Aug 27, 2024
Tweak register blockhash for tests + add optional feature set parameter into bank for fuzzing
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Aug 27, 2024
Tweak register blockhash for tests + add optional feature set parameter into bank for fuzzing
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Aug 27, 2024
Tweak register blockhash for tests + add optional feature set parameter into bank for fuzzing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants