Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

rpc-sts: respect app exit in tx receiver thread #27404

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

t-nelson
Copy link
Contributor

@t-nelson t-nelson commented Aug 25, 2022

Problem

RPC STS ignores app exit, zombieing the process in some fatal error cases

Summary of Changes

check exit signal in tx receiver thread loop

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the other loop in this service is already doing this

Copy link
Contributor

@lijunwangs lijunwangs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@t-nelson t-nelson merged commit 14c60ba into solana-labs:master Aug 26, 2022
@t-nelson t-nelson deleted the rse branch August 26, 2022 16:53
mergify bot added a commit that referenced this pull request Aug 26, 2022
…7423)

rpc-sts: respect app exit in tx receiver thread

(cherry picked from commit 14c60ba)

Co-authored-by: Trent Nelson <[email protected]>
mergify bot added a commit that referenced this pull request Aug 27, 2022
…7422)

rpc-sts: respect app exit in tx receiver thread

(cherry picked from commit 14c60ba)

Co-authored-by: Trent Nelson <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants