Fix quic staked chunking #27402
Merged
Fix quic staked chunking #27402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
approved these changes
Aug 25, 2022
|
We should cherry pick it to v1.11 as well. |
pgarg66
added
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
(cherry picked from commit b7b03cb)
mergify bot
added a commit
that referenced
this pull request
Aug 26, 2022
Fix quic staked chunking (#27402) (cherry picked from commit b7b03cb) Co-authored-by: ryleung-solana <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 10, 2022
) Fix quic staked chunking (solana-labs#27402) (cherry picked from commit b7b03cb) Co-authored-by: ryleung-solana <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 13, 2022
) Fix quic staked chunking (solana-labs#27402) (cherry picked from commit b7b03cb) Co-authored-by: ryleung-solana <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 13, 2022
) Fix quic staked chunking (solana-labs#27402) (cherry picked from commit b7b03cb) Co-authored-by: ryleung-solana <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 13, 2022
) Fix quic staked chunking (solana-labs#27402) (cherry picked from commit b7b03cb) Co-authored-by: ryleung-solana <[email protected]>
lijunwangs
pushed a commit
that referenced
this pull request
Sep 14, 2022
Fix quic staked chunking (#27402) (cherry picked from commit b7b03cb) Co-authored-by: ryleung-solana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently chunking is broken for quic batch send. The chunk size represents the number of concurrent streams, not the number of chunks, since we iterate through all the chunks one at a time, and call join_all on the elements of each chunk (which schedules them all concurrently on the runtime). We currently target number of chunks, rather than chunk size, meaning that with a larger number of chunks (such as with staked nodes), each chunk is actually smaller, meaning staked nodes actually open fewer streams at the same time.
Summary of Changes
Fix the quic batch send chunking
Fixes #