Lint shell scripts in CI

ci/buildkite.yml

@@ -29,6 +29,8 @@ steps:
         user: "998:997" # buildkite-agent:buildkite-agent
   - command: "ci/test-cuda.sh"
     label: "cuda"
+  - command: "ci/shellcheck.sh"
+    label: "shellcheck [public]"
   - wait
   - command: "ci/publish.sh"
     label: "publish release artifacts"

ci/coverage.sh

@@ -1,9 +1,10 @@
 #!/bin/bash -e
 
-cd $(dirname $0)/..
+cd "$(dirname "$0")/.."
 
 if [[ -r ~/.cargo/env ]]; then
   # Pick up local install of kcov/cargo-kcov
+  # shellcheck disable=SC1090
   source ~/.cargo/env
 fi
 

ci/publish.sh

@@ -1,6 +1,6 @@
 #!/bin/bash -e
 
-cd $(dirname $0)/..
+cd "$(dirname "$0")/.."
 
 if [[ -z "$BUILDKITE_TAG" ]]; then
   # Skip publish if this is not a tagged release

ci/shellcheck.sh

@@ -0,0 +1,14 @@
+#!/bin/bash -e
+#
+# Reference: https://github.com/koalaman/shellcheck/wiki/Directive
+
+cd "$(dirname "$0")/.."
+
+set -x
+docker pull koalaman/shellcheck
+find . -name "*.sh" -not -regex ".*/.cargo/.*" -print0 \
+  | xargs -0 \
+      docker run -w /work -v "$PWD:/work" \
+        koalaman/shellcheck --color=always --external-sources --shell=bash
+
+exit 0

ci/test-cuda.sh

@@ -1,17 +1,15 @@
 #!/bin/bash -e
 
-cd $(dirname $0)/..
+cd "$(dirname "$0")/.."
 
-if [[ -z "$libcuda_verify_ed25519_URL" ]]; then
-  echo libcuda_verify_ed25519_URL undefined
-  exit 1
-fi
+: "${libcuda_verify_ed25519_URL:?environment variable undefined}"
 
 export LD_LIBRARY_PATH=/usr/local/cuda/lib64
 export PATH=$PATH:/usr/local/cuda/bin
 curl -X GET -o libcuda_verify_ed25519.a "$libcuda_verify_ed25519_URL"
 
-source $HOME/.cargo/env
+# shellcheck disable=SC1090    # <-- shellcheck can't follow ~
+source ~/.cargo/env
 cargo test --features=cuda
 
 exit 0

ci/test-ignored.sh

@@ -1,6 +1,6 @@
 #!/bin/bash -e
 
-cd $(dirname $0)/..
+cd "$(dirname "$0")/.."
 
 rustc --version
 cargo --version

ci/test-nightly.sh

@@ -1,6 +1,6 @@
 #!/bin/bash -e
 
-cd $(dirname $0)/..
+cd "$(dirname "$0")/.."
 
 rustc --version
 cargo --version

ci/test-stable.sh

@@ -1,6 +1,6 @@
 #!/bin/bash -e
 
-cd $(dirname $0)/..
+cd "$(dirname "$0")/.."
 
 rustc --version
 cargo --version

multinode-demo/client.sh

@@ -1,5 +1,16 @@
-#!/bin/bash
+#!/bin/bash -e
+
+if [[ -z "$1" ]]; then
+  echo "usage: $0 [leader machine]"
+  exit 1
+fi
+
+LEADER="$1"
+
+set -x
 export RUST_LOG=solana=info
-rsync -v -e ssh $1:~/solana/leader.json .
-rsync -v -e ssh $1:~/solana/mint-demo.json .
-cat mint-demo.json | cargo run --release --bin solana-client-demo -- -l leader.json -c 8100 -n 1
+rsync -v -e ssh "$LEADER:~/solana/leader.json" .
+rsync -v -e ssh "$LEADER:~/solana/mint-demo.json" .
+
+cargo run --release --bin solana-client-demo -- \
+  -l leader.json -c 8100 -n 1 < mint-demo.json

multinode-demo/validator.sh

@@ -1,9 +1,24 @@
-#!/bin/bash
-rsync -v -e ssh $1:~/solana/mint-demo.json .
-rsync -v -e ssh $1:~/solana/leader.json .
-rsync -v -e ssh $1:~/solana/genesis.log .
-rsync -v -e ssh $1:~/solana/leader.log .
-rsync -v -e ssh $1:~/solana/libcuda_verify_ed25519.a .
+#!/bin/bash -e
+
+if [[ -z "$1" ]]; then
+  echo "usage: $0 [leader machine]"
+  exit 1
+fi
+
+LEADER="$1"
+
+set -x
+
+rsync -v -e ssh "$LEADER:~/solana/mint-demo.json" .
+rsync -v -e ssh "$LEADER:~/solana/leader.json" .
+rsync -v -e ssh "$LEADER:~/solana/genesis.log" .
+rsync -v -e ssh "$LEADER:~/solana/leader.log" .
+rsync -v -e ssh "$LEADER:~/solana/libcuda_verify_ed25519.a" .
+
 export RUST_LOG=solana=info
+
 sudo sysctl -w net.core.rmem_max=26214400
-cat genesis.log leader.log | cargo run --release --features cuda --bin solana-fullnode -- -l validator.json -s validator.json -v leader.json -b 9000 -d 2>&1 | tee validator-tee.log
+
+cat genesis.log leader.log | \
+  cargo run --release --features cuda --bin solana-fullnode -- \
+    -l validator.json -s validator.json -v leader.json -b 9000 -d 2>&1 | tee validator-tee.log