This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
zk-token-sdk:add length checks #27389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
Aug 31, 2022
* zk-token-sdk: add length check for ristretto encodings * zk-token-sdk: add type check for sigma proofs (cherry picked from commit 4c94493)
mergify bot
added a commit
that referenced
this pull request
Aug 31, 2022
zk-token-sdk:add length checks (#27389) * zk-token-sdk: add length check for ristretto encodings * zk-token-sdk: add type check for sigma proofs (cherry picked from commit 4c94493) Co-authored-by: samkim-crypto <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the decoding of some of the cryptographic objects in the zk-token-sdk could panic when the supplied byte slice is of different size.
Summary of Changes
Add length checks on slices during decoding of cryptographic objects.