Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get_multiple_accounts to BenchTpsClient #27379

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

KirillLykov
Copy link
Contributor

@KirillLykov KirillLykov commented Aug 24, 2022

Problem

It turned out that requesting durable nonce blockhashes one by one is too expensive.
By requesting 100 of them (maximum possible), tps is x3 higher.

These changes will be used for #27151
In particular, at this line:

match client.get_multiple_accounts(&nonce_pubkeys) {

Summary of Changes

  • add get_multiple_accounts to BenchTpsClient`
  • note, that this method is not implemented for BankClient because neither SyncClient nor AsyncClient doesn't have it

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@KirillLykov KirillLykov merged commit 8c81ed0 into solana-labs:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants