Make CommitmentLevel constructors const #27367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
CommitmentConfig
constructors cannot be used in const contexts. This isn't a big problem becauseCommitmentConfigs
's only field is public, so sdk users can just use e.g.CommitmentConfig{commitment: CommitmentLevel::Finalized}
instead ofCommitmentConfig::finalized()
, but using the latter would be a bit more convenient and there aren't any obvious-to-me reasons not to make the functionsconst
.Summary of Changes
Make the constructors
const
.Fixes #