This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
zk-token-sdk: constant time equality check for elgamal and aes key derivation #27364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
added a commit
that referenced
this pull request
Aug 31, 2022
…rivation (backport #27364) (#27491) zk-token-sdk: constant time equality check for elgamal and aes key derivation (#27364) zk-token-sdk: use constant time equality check for elgamal and aes key derivation (cherry picked from commit 5e8b8ab) Co-authored-by: samkim-crypto <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Authenticated encryption and ElGamal secret key can be derived from the signing key for easier key management. Currently, the key derivation function runs in non-constant-time since it uses the vanilla bit-wise equality check.
Summary of Changes
Use the constant time equality provided by the
subtlecrate for key derivation.