Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multinode test for two nodes rotating at 1 tick per slot #2735

Merged
merged 4 commits into from
Feb 13, 2019

Conversation

mvines
Copy link
Member

@mvines mvines commented Feb 12, 2019

Shows that two nodes can rotate at 2 ticks per slot fine, but at 1 ticks per slot two nodes fall down -- need debug still

@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #2735 into master will decrease coverage by <.1%.
The diff coverage is 83.3%.

@@           Coverage Diff            @@
##           master   #2735     +/-   ##
========================================
- Coverage    79.1%   79.1%   -0.1%     
========================================
  Files         115     115             
  Lines       19185   19183      -2     
========================================
- Hits        15177   15174      -3     
- Misses       4008    4009      +1

@mvines mvines removed the work in progress This isn't quite right yet label Feb 13, 2019
@mvines mvines changed the title Add mulitnode test for two nodes rotating at 1 tick per slot Add multinode test for two nodes rotating at 1 tick per slot Feb 13, 2019
@mvines
Copy link
Member Author

mvines commented Feb 13, 2019

I think this works now! Let's see if CI agrees. The problems were:

  1. Off-by-one in fullnode.rs
  2. It's too hard to create a valid ledger with blocktree::write_entries(). Some minor tweaks were needed to the test that built on some of other earlier work today in blocktree. But overall the problem still remains, blocktree::write_entries() needs more TLC

@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label Feb 13, 2019
@solana-grimes solana-grimes merged commit 863956d into solana-labs:master Feb 13, 2019
@mvines mvines deleted the tick1 branch February 13, 2019 05:17
wen-coding added a commit to wen-coding/solana that referenced this pull request Aug 28, 2024
solana-labs#2735)

* Send out HeaviestFork the first time entering the loop.

* Hack progress_changed and progress_last_sent so we don't need first_time_entering_loop.
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Aug 29, 2024
solana-labs#2735)

* Send out HeaviestFork the first time entering the loop.

* Hack progress_changed and progress_last_sent so we don't need first_time_entering_loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants