-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multinode test for two nodes rotating at 1 tick per slot #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2735 +/- ##
========================================
- Coverage 79.1% 79.1% -0.1%
========================================
Files 115 115
Lines 19185 19183 -2
========================================
- Hits 15177 15174 -3
- Misses 4008 4009 +1 |
mvines
changed the title
Add mulitnode test for two nodes rotating at 1 tick per slot
Add multinode test for two nodes rotating at 1 tick per slot
Feb 13, 2019
I think this works now! Let's see if CI agrees. The problems were:
|
wen-coding
added a commit
to wen-coding/solana
that referenced
this pull request
Aug 28, 2024
solana-labs#2735) * Send out HeaviestFork the first time entering the loop. * Hack progress_changed and progress_last_sent so we don't need first_time_entering_loop.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Aug 29, 2024
solana-labs#2735) * Send out HeaviestFork the first time entering the loop. * Hack progress_changed and progress_last_sent so we don't need first_time_entering_loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows that two nodes can rotate at 2 ticks per slot fine, but at 1 ticks per slot two nodes fall down -- need debug still