only READ BankIncrementalSnapshotPersistence in 1.11 #27345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I kicked CI |
|
And likely the serde snapshot test needs to be updated. Either writing the fields for the test, removing the test for v1.11, or just ensuring that reading the new fields works. |
jeffwashington
force-pushed
the
aug41
branch
2 times, most recently
from
e71bfa0 to
7fe14ce
Compare
|
both failures were legit. Yay, tests! |
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Sep 13, 2022
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Sep 13, 2022
only READ BankIncrementalSnapshotPersistence in 1.11 (solana-labs#27345) serialize incremental_snapshot_hash (backport solana-labs#26839) (solana-labs#27212)
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Sep 13, 2022
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Sep 13, 2022
only READ BankIncrementalSnapshotPersistence in 1.11 (solana-labs#27345) serialize incremental_snapshot_hash (backport solana-labs#26839) (solana-labs#27212)
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Sep 14, 2022
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Sep 14, 2022
only READ BankIncrementalSnapshotPersistence in 1.11 (solana-labs#27345) serialize incremental_snapshot_hash (backport solana-labs#26839) (solana-labs#27212)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #27212
If we save these new fields in 1.11, then 1.10 will be unable to load snapshots created in 1.11
Summary of Changes
In 1.11, just READ the new fields, but do not write them.
Fixes #