Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use-quic flag to allow for using quic in program deploy #27319

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

sakridge
Copy link
Member

Problem

Program deploy uses UDP transaction send and has no QUIC path.

Summary of Changes

Add --use-quic flag so that solana program deploy can use QUIC to send transactions.

Fixes #

@sakridge sakridge force-pushed the quic-program-deploy branch from df1cbc2 to 8e84efd Compare August 23, 2022 00:30
@sakridge
Copy link
Member Author

sakridge commented Aug 23, 2022

Seems to work:

cli % RUST_LOG=info crr solana deploy -k ../id.json --use-quic ../spl_token-3.3.0.so -u https://api.testnet.solana.com

[2022-08-23T00:31:14.856908000Z INFO  solana_metrics::metrics] datapoint: quic-client-connection-stats cache_hits=3i cache_misses=0i cache_evictions=0i eviction_time_ms=0i get_connection
_ms=0i get_connection_lock_ms=0i get_connection_hit_ms=0i get_connection_miss_ms=0i make_conn
ection_ms=0i total_connections=0i connection_reuse=3i connection_errors=0i zero_rtt_accepts=0
i zero_rtt_rejects=0i congestion_events=0i tx_streams_blocked_uni=0i tx_data_blocked=0i tx_ac
ks=9i num_packets=3i total_batches=3i batch_failure=0i
⠤  95.2% | Checking transaction status...           [block height 119040903; re-sign in 221 b
[2022-08-23T00:31:15.010906000Z INFO  solana_client::nonblocking::quic_client] Made connection to 109.238.11.17:8009 id 4984199696 try_count 0
[2022-08-23T00:31:15.019218000Z INFO  solana_client::nonblocking::quic_client] Made connection to 46.4.28.38:8009 id 4984107536 try_count 0
[2022-08-23T00:31:15.019806000Z INFO  solana_client::nonblocking::quic_client] Made connection to 142.132.252.162:8009 id 4984291856 try_count 0
⠐  95.2% | Sending 1/7 transactions
[2022-08-23T00:31:15.355998000Z INFO  solana_client::nonblocking::quic_client] Made connection to 5.9.59.245:8009 id 4992084496 try_count 0

Program Id: GD1Y5WesUnT6871Msz1HA92o4Jg71fg2Hh8jZnSvEiBJ

@sakridge sakridge marked this pull request as ready for review August 23, 2022 00:32
@sakridge sakridge requested a review from mvines August 24, 2022 00:02
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me

@sakridge sakridge merged commit 5a100ab into solana-labs:master Aug 25, 2022
@sakridge sakridge deleted the quic-program-deploy branch August 25, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants