Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solana deploy subcommand to warn non-upgradable #27264

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

coudron
Copy link
Contributor

@coudron coudron commented Aug 19, 2022

Problem

solana deploy --help made no mention of deploy being non-upgradeable and the preferred operation is solana program deploy

Summary of Changes

Updated the subcommand 'about' text to give more information

Fixes #27228

Update the about text for `solana deploy` to warn this is only for non-upgradeable deploys. Fixes solana-labs#27228
@mergify mergify bot added the community Community contribution label Aug 19, 2022
@mergify mergify bot requested a review from a team August 19, 2022 17:54
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jstarry jstarry merged commit 65070df into solana-labs:master Aug 22, 2022
mergify bot pushed a commit that referenced this pull request Aug 22, 2022
Update subcommand text to warn deploy deprecated

Update the about text for `solana deploy` to warn this is only for non-upgradeable deploys. Fixes #27228

(cherry picked from commit 65070df)
mergify bot added a commit that referenced this pull request Aug 22, 2022
…7264) (#27291)

Update `solana deploy` subcommand to warn non-upgradable (#27264)

Update subcommand text to warn deploy deprecated

Update the about text for `solana deploy` to warn this is only for non-upgradeable deploys. Fixes #27228

(cherry picked from commit 65070df)

Co-authored-by: Chris Coudron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI solana deploy makes no mention of being non-upgradeable
3 participants