Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds hash domain to ping-pong protocol (backport #27193) #27244

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 18, 2022

This is an automatic backport of pull request #27193 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Aug 18, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Aug 18, 2022

automerge label removed due to a CI failure

@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Aug 18, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Aug 19, 2022

automerge label removed due to a CI failure

@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Aug 19, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Aug 19, 2022

automerge label removed due to a CI failure

@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Aug 19, 2022
@behzadnouri
Copy link
Contributor

@Mergifyio rebase

In order to maintain backward compatibility, for now the responding node
will hash the token both with and without domain so that the other node
will accept the response regardless of its upgrade status.
Once the cluster has upgraded to the new code, we will remove the legacy
domain = false case.

(cherry picked from commit 6928b2a)
@mergify
Copy link
Contributor Author

mergify bot commented Aug 19, 2022

rebase

✅ Branch has been successfully rebased

@brooksprumo brooksprumo force-pushed the mergify/bp/v1.11/pr-27193 branch from 4323a07 to b03d6ae Compare August 19, 2022 13:54
@solana-grimes
Copy link
Contributor

😱 New commits were pushed while the automerge label was present.

@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Aug 19, 2022
@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Aug 19, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Aug 19, 2022

automerge label removed due to a CI failure

@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Aug 19, 2022
@mergify mergify bot merged commit 4e08c4d into v1.11 Aug 19, 2022
@mergify mergify bot deleted the mergify/bp/v1.11/pr-27193 branch August 19, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants