-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds hash domain to ping-pong protocol (backport #27193) #27244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
automerge
Merge this Pull Request automatically once CI passes
and removed
automerge
Merge this Pull Request automatically once CI passes
labels
Aug 18, 2022
automerge label removed due to a CI failure |
mergify
bot
added
the
automerge
Merge this Pull Request automatically once CI passes
label
Aug 18, 2022
automerge label removed due to a CI failure |
mergify
bot
added
automerge
Merge this Pull Request automatically once CI passes
and removed
automerge
Merge this Pull Request automatically once CI passes
labels
Aug 19, 2022
automerge label removed due to a CI failure |
mergify
bot
added
automerge
Merge this Pull Request automatically once CI passes
and removed
automerge
Merge this Pull Request automatically once CI passes
labels
Aug 19, 2022
@Mergifyio rebase |
In order to maintain backward compatibility, for now the responding node will hash the token both with and without domain so that the other node will accept the response regardless of its upgrade status. Once the cluster has upgraded to the new code, we will remove the legacy domain = false case. (cherry picked from commit 6928b2a)
✅ Branch has been successfully rebased |
brooksprumo
force-pushed
the
mergify/bp/v1.11/pr-27193
branch
from
August 19, 2022 13:54
4323a07
to
b03d6ae
Compare
😱 New commits were pushed while the automerge label was present. |
solana-grimes
removed
the
automerge
Merge this Pull Request automatically once CI passes
label
Aug 19, 2022
mergify
bot
added
automerge
Merge this Pull Request automatically once CI passes
and removed
automerge
Merge this Pull Request automatically once CI passes
labels
Aug 19, 2022
automerge label removed due to a CI failure |
mergify
bot
added
the
automerge
Merge this Pull Request automatically once CI passes
label
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #27193 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com