Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize thread names to make standard thread monitoring tools more usable #27237

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

mvines
Copy link
Member

@mvines mvines commented Aug 18, 2022

Tenets:

  1. Limit thread names to 15 characters
  2. Prefix all Solana-controlled threads with "sol"
  3. Use Camel case. It's more character dense than Snake or Kebab case
Before
$ pstree -t 22875
solana-validato─┬─8*[{ClusterInfo::go}]
                ├─{blockstore_0}
                ├─{blockstore_10}
                ├─{blockstore_11}
                ├─{blockstore_12}
                ├─{blockstore_13}
                ├─{blockstore_14}
                ├─{blockstore_15}
                ├─{blockstore_16}
                ├─{blockstore_17}
                ├─{blockstore_18}
                ├─{blockstore_19}
                ├─{blockstore_1}
                ├─{blockstore_20}
                ├─{blockstore_21}
                ├─{blockstore_22}
                ├─{blockstore_23}
                ├─{blockstore_24}
                ├─{blockstore_25}
                ├─{blockstore_26}
                ├─{blockstore_27}
                ├─{blockstore_28}
                ├─{blockstore_29}
                ├─{blockstore_2}
                ├─{blockstore_30}
                ├─{blockstore_31}
                ├─{blockstore_3}
                ├─{blockstore_4}
                ├─{blockstore_5}
                ├─{blockstore_6}
                ├─{blockstore_7}
                ├─{blockstore_8}
                ├─{blockstore_9}
                ├─32*[{blockstore_proc}]
                ├─{completed-data-}
                ├─{entry_0}
                ├─{entry_10}
                ├─{entry_11}
                ├─{entry_12}
                ├─{entry_13}
                ├─{entry_14}
                ├─{entry_15}
                ├─{entry_16}
                ├─{entry_17}
                ├─{entry_18}
                ├─{entry_19}
                ├─{entry_1}
                ├─{entry_20}
                ├─{entry_21}
                ├─{entry_22}
                ├─{entry_23}
                ├─{entry_24}
                ├─{entry_25}
                ├─{entry_26}
                ├─{entry_27}
                ├─{entry_28}
                ├─{entry_29}
                ├─{entry_2}
                ├─{entry_30}
                ├─{entry_31}
                ├─{entry_3}
                ├─{entry_4}
                ├─{entry_5}
                ├─{entry_6}
                ├─{entry_7}
                ├─{entry_8}
                ├─{entry_9}
                ├─2*[{find-packet-sen}]
                ├─8*[{gossip-consume-}]
                ├─{gossip-consume}
                ├─{metric_report_r}
                ├─{poh_timing_repo}
                ├─{retransmit-0}
                ├─{retransmit-1}
                ├─{retransmit-2}
                ├─{retransmit-3}
                ├─{retransmit-4}
                ├─{retransmit-5}
                ├─{retransmit-6}
                ├─{retransmit-7}
                ├─8*[{rocksdb:high}]
                ├─32*[{rocksdb:low}]
                ├─{send-tx-receive}
                ├─{send-tx-retry}
                ├─{shred-verifier}
                ├─{shredder_0}
                ├─{shredder_10}
                ├─{shredder_11}
                ├─{shredder_12}
                ├─{shredder_13}
                ├─{shredder_14}
                ├─{shredder_15}
                ├─{shredder_1}
                ├─{shredder_2}
                ├─{shredder_3}
                ├─{shredder_4}
                ├─{shredder_5}
                ├─{shredder_6}
                ├─{shredder_7}
                ├─{shredder_8}
                ├─{shredder_9}
                ├─{sigverify_0}
                ├─{sigverify_10}
                ├─{sigverify_11}
                ├─{sigverify_12}
                ├─{sigverify_13}
                ├─{sigverify_14}
                ├─{sigverify_15}
                ├─{sigverify_1}
                ├─{sigverify_2}
                ├─{sigverify_3}
                ├─{sigverify_4}
                ├─{sigverify_5}
                ├─{sigverify_6}
                ├─{sigverify_7}
                ├─{sigverify_8}
                ├─{sigverify_9}
                ├─16*[{sigverify_shred}]
                ├─{snapshot-packag}
                ├─3*[{sol-adminrpc-el}]
                ├─{sol-drop-b-serv}
                ├─8*[{sol-gossip-work}]
                ├─4*[{sol-rpc-el}]
                ├─{sol-sn-updater}
                ├─{sol-sub-notif-0}
                ├─7*[{sol-sub-notif-1}]
                ├─{sol-sub-notif-2}
                ├─{sol-sub-notif-3}
                ├─{sol-sub-notif-4}
                ├─{sol-sub-notif-5}
                ├─{sol-sub-notif-6}
                ├─{sol-sub-notif-7}
                ├─{sol-sub-notif-8}
                ├─{sol-sub-notif-9}
                ├─{sol-vote-servic}
                ├─{sol-warm-quic-s}
                ├─{solana-adminrpc}
                ├─{solana-aggregat}
                ├─{solana-ancestor}
                ├─6*[{solana-banking-}]
                ├─{solana-bg-accou}
                ├─8*[{solana-broadcas}]
                ├─{solana-check-du}
                ├─8*[{solana-cleanup-}]
                ├─{solana-cluster-}
                ├─3*[{solana-cluster_}]
                ├─{solana-cost-upd}
                ├─16*[{solana-db-accou}]
                ├─{solana-db-store}
                ├─2*[{solana-fetch-st}]
                ├─{solana-gossip}
                ├─{solana-hash-acc}
                ├─8*[{solana-idx-flus}]
                ├─2*[{solana-jsonrpc}]
                ├─{solana-listen}
                ├─{solana-manage-a}
                ├─{solana-optimist}
                ├─{solana-poh-serv}
                ├─{solana-pubsub}
                ├─6*[{solana-qos-serv}]
                ├─61*[{solana-receiver}]
                ├─{solana-repair-l}
                ├─{solana-repair-s}
                ├─{solana-replay-s}
                ├─2*[{solana-responde}]
                ├─{solana-retransm}
                ├─{solana-rpc-comp}
                ├─{solana-rpc-noti}
                ├─{solana-stats-re}
                ├─3*[{solana-tvu-fetc}]
                ├─37*[{solana-validato}]
                ├─2*[{solana-verifier}]
                ├─{solana-window-i}
                ├─{system-monitor}
                ├─76*[{tokio-runtime-w}]
                ├─{window-insert-0}
                ├─{window-insert-1}
                ├─{window-insert-2}
                ├─{window-insert-3}
                ├─{window-insert-4}
                ├─{window-insert-5}
                ├─{window-insert-6}
                └─{window-insert-7}
After
```
$ pstree -p 1388948 -t
solana-validato(1388948)─┬─{rocksdb:high}(1389086)
                         ├─{rocksdb:high}(1389087)
                         ├─{rocksdb:high}(1389088)
                         ├─{rocksdb:high}(1389089)
                         ├─{rocksdb:high}(1389090)
                         ├─{rocksdb:high}(1389091)
                         ├─{rocksdb:high}(1389092)
                         ├─{rocksdb:high}(1389093)
                         ├─{rocksdb:high}(1389094)
                         ├─{rocksdb:low}(1389050)
                         ├─{rocksdb:low}(1389051)
                         ├─{rocksdb:low}(1389052)
                         ├─{rocksdb:low}(1389053)
                         ├─{rocksdb:low}(1389054)
                         ├─{rocksdb:low}(1389055)
                         ├─{rocksdb:low}(1389056)
                         ├─{rocksdb:low}(1389057)
                         ├─{rocksdb:low}(1389058)
                         ├─{rocksdb:low}(1389059)
                         ├─{rocksdb:low}(1389060)
                         ├─{rocksdb:low}(1389061)
                         ├─{rocksdb:low}(1389062)
                         ├─{rocksdb:low}(1389063)
                         ├─{rocksdb:low}(1389064)
                         ├─{rocksdb:low}(1389065)
                         ├─{rocksdb:low}(1389066)
                         ├─{rocksdb:low}(1389067)
                         ├─{rocksdb:low}(1389068)
                         ├─{rocksdb:low}(1389069)
                         ├─{rocksdb:low}(1389070)
                         ├─{rocksdb:low}(1389071)
                         ├─{rocksdb:low}(1389072)
                         ├─{rocksdb:low}(1389073)
                         ├─{rocksdb:low}(1389074)
                         ├─{rocksdb:low}(1389075)
                         ├─{rocksdb:low}(1389076)
                         ├─{rocksdb:low}(1389077)
                         ├─{rocksdb:low}(1389078)
                         ├─{rocksdb:low}(1389079)
                         ├─{rocksdb:low}(1389080)
                         ├─{rocksdb:low}(1389081)
                         ├─{rocksdb:low}(1389082)
                         ├─{rocksdb:low}(1389083)
                         ├─{rocksdb:low}(1389084)
                         ├─{rocksdb:low}(1389085)
                         ├─{solAccounts00}(1389488)
                         ├─{solAccounts01}(1389489)
                         ├─{solAccounts02}(1389490)
                         ├─{solAccounts03}(1389491)
                         ├─{solAccounts04}(1389492)
                         ├─{solAccounts05}(1389493)
                         ├─{solAccounts06}(1389494)
                         ├─{solAccounts07}(1389495)
                         ├─{solAccounts08}(1389496)
                         ├─{solAccountsDb00}(1389470)
                         ├─{solAccountsDb01}(1389471)
                         ├─{solAccountsDb02}(1389472)
                         ├─{solAccountsDb03}(1389473)
                         ├─{solAccountsDb04}(1389474)
                         ├─{solAccountsDb05}(1389475)
                         ├─{solAccountsDb06}(1389476)
                         ├─{solAccountsDb07}(1389477)
                         ├─{solAccountsDb08}(1389478)
                         ├─{solAccountsDb09}(1389479)
                         ├─{solAccountsDb10}(1389480)
                         ├─{solAccountsDb11}(1389481)
                         ├─{solAccountsDb12}(1389482)
                         ├─{solAccountsDb13}(1389483)
                         ├─{solAccountsDb14}(1389484)
                         ├─{solAccountsDb15}(1389485)
                         ├─{solAccountsDb16}(1389486)
                         ├─{solAccountsDb17}(1389487)
                         ├─{solAcctHashVer}(1389841)
                         ├─{solAdminRpcEl}(1388992)
                         ├─{solAdminRpcEl}(1388993)
                         ├─{solAdminRpcEl}(1388994)
                         ├─{solAdminRpc}(1388995)
                         ├─{solAggCommitSvc}(1389854)
                         ├─{solAncHashesSvc}(1389830)
                         ├─{solBanknStgTx00}(1389959)
                         ├─{solBanknStgTx01}(1389961)
                         ├─{solBanknStgTx02}(1389964)
                         ├─{solBanknStgTx03}(1389967)
                         ├─{solBanknStgTx04}(1389968)
                         ├─{solBanknStgTx05}(1389970)
                         ├─{solBgAccounts}(1389867)
                         ├─{solBroadcastRec}(1389986)
                         ├─{solBroadcastRec}(1389988)
                         ├─{solBroadcastRtx}(1389989)
                         ├─{solBroadcastTx}(1389977)
                         ├─{solBroadcastTx}(1389980)
                         ├─{solBroadcastTx}(1389982)
                         ├─{solBroadcastTx}(1389985)
                         ├─{solBroadcast}(1389974)
                         ├─{solBstore00}(1389530)
                         ├─{solBstore00}(1389919)
                         ├─{solBstore01}(1389531)
                         ├─{solBstore01}(1389921)
                         ├─{solBstore02}(1389532)
                         ├─{solBstore02}(1389923)
                         ├─{solBstore03}(1389533)
                         ├─{solBstore03}(1389924)
                         ├─{solBstore04}(1389534)
                         ├─{solBstore04}(1389927)
                         ├─{solBstore05}(1389535)
                         ├─{solBstore05}(1389928)
                         ├─{solBstore06}(1389536)
                         ├─{solBstore06}(1389929)
                         ├─{solBstore07}(1389537)
                         ├─{solBstore07}(1389930)
                         ├─{solBstore08}(1389538)
                         ├─{solBstore08}(1389931)
                         ├─{solBstore09}(1389539)
                         ├─{solBstore09}(1389932)
                         ├─{solBstore10}(1389540)
                         ├─{solBstore10}(1389933)
                         ├─{solBstore11}(1389541)
                         ├─{solBstore11}(1389935)
                         ├─{solBstore12}(1389542)
                         ├─{solBstore12}(1389937)
                         ├─{solBstore13}(1389543)
                         ├─{solBstore13}(1389939)
                         ├─{solBstore14}(1389544)
                         ├─{solBstore14}(1389940)
                         ├─{solBstore15}(1389545)
                         ├─{solBstore15}(1389942)
                         ├─{solBstore16}(1389546)
                         ├─{solBstore16}(1389943)
                         ├─{solBstore17}(1389547)
                         ├─{solBstore17}(1389945)
                         ├─{solBstoreProc00}(1389566)
                         ├─{solBstoreProc00}(1389990)
                         ├─{solBstoreProc01}(1389567)
                         ├─{solBstoreProc01}(1389991)
                         ├─{solBstoreProc02}(1389568)
                         ├─{solBstoreProc02}(1389992)
                         ├─{solBstoreProc03}(1389569)
                         ├─{solBstoreProc03}(1389993)
                         ├─{solBstoreProc04}(1389570)
                         ├─{solBstoreProc04}(1389994)
                         ├─{solBstoreProc05}(1389571)
                         ├─{solBstoreProc05}(1389995)
                         ├─{solBstoreProc06}(1389572)
                         ├─{solBstoreProc06}(1389996)
                         ├─{solBstoreProc07}(1389573)
                         ├─{solBstoreProc07}(1389997)
                         ├─{solBstoreProc08}(1389574)
                         ├─{solBstoreProc08}(1389998)
                         ├─{solBstoreProc09}(1389575)
                         ├─{solBstoreProc09}(1389999)
                         ├─{solBstoreProc10}(1389576)
                         ├─{solBstoreProc10}(1390000)
                         ├─{solBstoreProc11}(1389577)
                         ├─{solBstoreProc11}(1390001)
                         ├─{solBstoreProc12}(1389578)
                         ├─{solBstoreProc12}(1390002)
                         ├─{solBstoreProc13}(1389579)
                         ├─{solBstoreProc13}(1390003)
                         ├─{solBstoreProc14}(1389580)
                         ├─{solBstoreProc14}(1390004)
                         ├─{solBstoreProc15}(1389581)
                         ├─{solBstoreProc15}(1390005)
                         ├─{solBstoreProc16}(1389582)
                         ├─{solBstoreProc16}(1390006)
                         ├─{solBstoreProc17}(1389583)
                         ├─{solBstoreProc17}(1390007)
                         ├─{solCiBankSend}(1389955)
                         ├─{solCiProcVotes}(1389958)
                         ├─{solCiVoteLstnr}(1389953)
                         ├─{solClusterSlots}(1389821)
                         ├─{solComplDataSet}(1389701)
                         ├─{solCostUpdtSvc}(1389847)
                         ├─{solDbStoreHashr}(1389497)
                         ├─{solDropBankSrvc}(1389851)
                         ├─{solEntry00}(1389548)
                         ├─{solEntry00}(1389947)
                         ├─{solEntry01}(1389549)
                         ├─{solEntry01}(1389949)
                         ├─{solEntry02}(1389550)
                         ├─{solEntry02}(1389950)
                         ├─{solEntry03}(1389551)
                         ├─{solEntry03}(1389951)
                         ├─{solEntry04}(1389552)
                         ├─{solEntry04}(1389954)
                         ├─{solEntry05}(1389553)
                         ├─{solEntry05}(1389956)
                         ├─{solEntry06}(1389554)
                         ├─{solEntry06}(1389957)
                         ├─{solEntry07}(1389555)
                         ├─{solEntry07}(1389960)
                         ├─{solEntry08}(1389556)
                         ├─{solEntry08}(1389962)
                         ├─{solEntry09}(1389557)
                         ├─{solEntry09}(1389963)
                         ├─{solEntry10}(1389558)
                         ├─{solEntry10}(1389965)
                         ├─{solEntry11}(1389559)
                         ├─{solEntry11}(1389966)
                         ├─{solEntry12}(1389560)
                         ├─{solEntry12}(1389969)
                         ├─{solEntry13}(1389561)
                         ├─{solEntry13}(1389971)
                         ├─{solEntry14}(1389562)
                         ├─{solEntry14}(1389972)
                         ├─{solEntry15}(1389563)
                         ├─{solEntry15}(1389976)
                         ├─{solEntry16}(1389564)
                         ├─{solEntry16}(1389978)
                         ├─{solEntry17}(1389565)
                         ├─{solEntry17}(1389981)
                         ├─{solFetchStgFwRx}(1389914)
                         ├─{solFetchStgMetr}(1389915)
                         ├─{solGossipCons00}(1389754)
                         ├─{solGossipCons01}(1389755)
                         ├─{solGossipCons02}(1389756)
                         ├─{solGossipCons03}(1389757)
                         ├─{solGossipCons04}(1389758)
                         ├─{solGossipCons05}(1389759)
                         ├─{solGossipCons06}(1389760)
                         ├─{solGossipCons07}(1389761)
                         ├─{solGossipConsum}(1389762)
                         ├─{solGossipListen}(1389771)
                         ├─{solGossipWork00}(1389763)
                         ├─{solGossipWork01}(1389764)
                         ├─{solGossipWork02}(1389765)
                         ├─{solGossipWork03}(1389766)
                         ├─{solGossipWork04}(1389767)
                         ├─{solGossipWork05}(1389768)
                         ├─{solGossipWork06}(1389769)
                         ├─{solGossipWork07}(1389770)
                         ├─{solGossip}(1389780)
                         ├─{solIdxFlusher00}(1389461)
                         ├─{solIdxFlusher01}(1389462)
                         ├─{solIdxFlusher02}(1389463)
                         ├─{solIdxFlusher03}(1389464)
                         ├─{solIdxFlusher04}(1389465)
                         ├─{solIdxFlusher05}(1389466)
                         ├─{solIdxFlusher06}(1389467)
                         ├─{solIdxFlusher07}(1389468)
                         ├─{solIdxFlusher08}(1389469)
                         ├─{solJsonRpcSvc}(1389708)
                         ├─{solJsonRpcSvc}(1389711)
                         ├─{solLedgerClean}(1389860)
                         ├─{solLedgerComp}(1389862)
                         ├─{solManAncReqs}(1389832)
                         ├─{solOpConfBnkTrk}(1389710)
                         ├─{solPktStake}(1389917)
                         ├─{solPktStake}(1389918)
                         ├─{solPohTickProd}(1389786)
                         ├─{solQosSvcMetr}(1389973)
                         ├─{solQosSvcMetr}(1389975)
                         ├─{solQosSvcMetr}(1389979)
                         ├─{solQosSvcMetr}(1389983)
                         ├─{solQosSvcMetr}(1389984)
                         ├─{solQosSvcMetr}(1389987)
                         ├─{solReceiver}(1389753)
                         ├─{solReceiver}(1389782)
                         ├─{solReceiver}(1389788)
                         ├─{solReceiver}(1389789)
                         ├─{solReceiver}(1389790)
                         ├─{solReceiver}(1389791)
                         ├─{solReceiver}(1389792)
                         ├─{solReceiver}(1389793)
                         ├─{solReceiver}(1389794)
                         ├─{solReceiver}(1389795)
                         ├─{solReceiver}(1389797)
                         ├─{solReceiver}(1389798)
                         ├─{solReceiver}(1389799)
                         ├─{solReceiver}(1389800)
                         ├─{solReceiver}(1389801)
                         ├─{solReceiver}(1389802)
                         ├─{solReceiver}(1389803)
                         ├─{solReceiver}(1389804)
                         ├─{solReceiver}(1389806)
                         ├─{solReceiver}(1389828)
                         ├─{solReceiver}(1389870)
                         ├─{solReceiver}(1389874)
                         ├─{solReceiver}(1389875)
                         ├─{solReceiver}(1389876)
                         ├─{solReceiver}(1389877)
                         ├─{solReceiver}(1389878)
                         ├─{solReceiver}(1389879)
                         ├─{solReceiver}(1389880)
                         ├─{solReceiver}(1389881)
                         ├─{solReceiver}(1389882)
                         ├─{solReceiver}(1389883)
                         ├─{solReceiver}(1389884)
                         ├─{solReceiver}(1389885)
                         ├─{solReceiver}(1389886)
                         ├─{solReceiver}(1389887)
                         ├─{solReceiver}(1389888)
                         ├─{solReceiver}(1389889)
                         ├─{solReceiver}(1389890)
                         ├─{solReceiver}(1389891)
                         ├─{solReceiver}(1389892)
                         ├─{solReceiver}(1389893)
                         ├─{solReceiver}(1389894)
                         ├─{solReceiver}(1389895)
                         ├─{solReceiver}(1389896)
                         ├─{solReceiver}(1389897)
                         ├─{solReceiver}(1389898)
                         ├─{solReceiver}(1389899)
                         ├─{solReceiver}(1389900)
                         ├─{solReceiver}(1389901)
                         ├─{solReceiver}(1389902)
                         ├─{solReceiver}(1389903)
                         ├─{solReceiver}(1389904)
                         ├─{solReceiver}(1389905)
                         ├─{solReceiver}(1389906)
                         ├─{solReceiver}(1389907)
                         ├─{solReceiver}(1389908)
                         ├─{solReceiver}(1389909)
                         ├─{solReceiver}(1389910)
                         ├─{solReceiver}(1389911)
                         ├─{solReceiver}(1389912)
                         ├─{solReceiver}(1389913)
                         ├─{solRepairListen}(1389784)
                         ├─{solRepairSvc}(1389825)
                         ├─{solReplayStage}(1389857)
                         ├─{solRetransmit00}(1389809)
                         ├─{solRetransmit01}(1389810)
                         ├─{solRetransmit02}(1389811)
                         ├─{solRetransmit03}(1389812)
                         ├─{solRetransmit04}(1389813)
                         ├─{solRetransmit05}(1389814)
                         ├─{solRetransmit06}(1389815)
                         ├─{solRetransmit07}(1389816)
                         ├─{solRetransmittr}(1389817)
                         ├─{solRocksCfMtrcs}(1389864)
                         ├─{solRpcComplSlot}(1389787)
                         ├─{solRpcEl}(1389702)
                         ├─{solRpcEl}(1389703)
                         ├─{solRpcEl}(1389704)
                         ├─{solRpcEl}(1389705)
                         ├─{solRpcPubSub}(1389709)
                         ├─{solRspndrRepair}(1389783)
                         ├─{solRspndrgossip}(1389781)
                         ├─{solRunGossip00}(1389772)
                         ├─{solRunGossip01}(1389773)
                         ├─{solRunGossip02}(1389774)
                         ├─{solRunGossip03}(1389775)
                         ├─{solRunGossip04}(1389776)
                         ├─{solRunGossip05}(1389777)
                         ├─{solRunGossip06}(1389778)
                         ├─{solRunGossip07}(1389779)
                         ├─{solSigVerifier}(1389808)
                         ├─{solSigVerifier}(1389948)
                         ├─{solSigVerifier}(1389952)
                         ├─{solSigVerify00}(1390008)
                         ├─{solSigVerify01}(1390009)
                         ├─{solSigVerify02}(1390010)
                         ├─{solSigVerify03}(1390011)
                         ├─{solSigVerify04}(1390012)
                         ├─{solSigVerify05}(1390013)
                         ├─{solSigVerify06}(1390014)
                         ├─{solSigVerify07}(1390015)
                         ├─{solSigVerify08}(1390016)
                         ├─{solSigVerify09}(1390017)
                         ├─{solSigVerify10}(1390018)
                         ├─{solSigVerify11}(1390019)
                         ├─{solSigVerify12}(1390020)
                         ├─{solSigVerify13}(1390021)
                         ├─{solSigVerify14}(1390022)
                         ├─{solSigVerify15}(1390023)
                         ├─{solSigVerify16}(1390024)
                         ├─{solSigVerify17}(1390025)
                         ├─{solSnapshotPkgr}(1389785)
                         ├─{solStakedNodeUd}(1389916)
                         ├─{solStatsReport}(1389752)
                         ├─{solStxReceive}(1389706)
                         ├─{solStxRetry}(1389707)
                         ├─{solSvrfyShred00}(1389818)
                         ├─{solSvrfyShred01}(1389819)
                         ├─{solSvrfyShred02}(1389820)
                         ├─{solSvrfyShred03}(1389822)
                         ├─{solSvrfyShred04}(1389823)
                         ├─{solSvrfyShred05}(1389824)
                         ├─{solSvrfyShred06}(1389826)
                         ├─{solSvrfyShred07}(1389827)
                         ├─{solSvrfyShred08}(1389829)
                         ├─{solSvrfyShred09}(1389831)
                         ├─{solSvrfyShred10}(1389833)
                         ├─{solSvrfyShred11}(1389835)
                         ├─{solSvrfyShred12}(1389836)
                         ├─{solSvrfyShred13}(1389839)
                         ├─{solSvrfyShred14}(1389840)
                         ├─{solSvrfyShred15}(1389842)
                         ├─{solSvrfyShred16}(1389843)
                         ├─{solSvrfyShred17}(1389848)
                         ├─{solSystemMonitr}(1389049)
                         ├─{solTvuFetchPMod}(1389796)
                         ├─{solTvuFetchPMod}(1389805)
                         ├─{solTvuFetchPMod}(1389807)
                         ├─{solTxCostMetr}(1389850)
                         ├─{solVoteService}(1389845)
                         ├─{solWinCheckDup}(1389834)
                         ├─{solWinInsert}(1389837)
                         ├─{solWindowRx}(1389838)
                         ├─{solWindowRx}(1389844)
                         ├─{solWindowRx}(1389846)
                         ├─{solWindowRx}(1389849)
                         ├─{solWindowRx}(1389852)
                         ├─{solWindowRx}(1389853)
                         ├─{solWindowRx}(1389855)
                         ├─{solWindowRx}(1389856)
                         ├─{solWindowRx}(1389858)
                         ├─{solWindowRx}(1389859)
                         ├─{solWindowRx}(1389861)
                         ├─{solWindowRx}(1389863)
                         ├─{solWindowRx}(1389865)
                         ├─{solWindowRx}(1389866)
                         ├─{solWindowRx}(1389868)
                         ├─{solWindowRx}(1389869)
                         ├─{solWindowRx}(1389871)
                         ├─{solWindowRx}(1389872)
                         ├─{solWindowRx}(1389873)
                         ├─{solana-validato}(1388990)
                         ├─{solana-validato}(1388991)
                         ├─{solana-validato}(1389413)
                         ├─{solana-validato}(1389415)
                         ├─{solana-validato}(1389416)
                         ├─{solana-validato}(1389417)
                         ├─{solana-validato}(1389418)
                         ├─{solana-validato}(1389419)
                         ├─{solana-validato}(1389420)
                         ├─{solana-validato}(1389421)
                         ├─{solana-validato}(1389422)
                         ├─{solana-validato}(1389423)
                         ├─{solana-validato}(1389424)
                         ├─{solana-validato}(1389425)
                         ├─{solana-validato}(1389426)
                         ├─{solana-validato}(1389427)
                         ├─{solana-validato}(1389428)
                         ├─{solana-validato}(1389429)
                         ├─{solana-validato}(1389430)
                         ├─{solana-validato}(1389431)
                         ├─{solana-validato}(1389432)
                         ├─{solana-validato}(1389433)
                         ├─{solana-validato}(1389434)
                         ├─{solana-validato}(1389435)
                         ├─{solana-validato}(1389436)
                         ├─{solana-validato}(1389437)
                         ├─{solana-validato}(1389438)
                         ├─{solana-validato}(1389439)
                         ├─{solana-validato}(1389440)
                         ├─{solana-validato}(1389441)
                         ├─{solana-validato}(1389442)
                         ├─{solana-validato}(1389443)
                         ├─{solana-validato}(1389444)
                         ├─{solana-validato}(1389445)
                         ├─{solana-validato}(1389446)
                         ├─{solana-validato}(1389447)
                         ├─{solana-validato}(1389448)
                         ├─{solana-validato}(1389449)
                         ├─{solana-validato}(1389450)
                         ├─{solana-validato}(1389934)
                         ├─{solana-validato}(1389946)
                         ├─{tokio-runtime-w}(1389712)
                         ├─{tokio-runtime-w}(1389713)
                         ├─{tokio-runtime-w}(1389714)
                         ├─{tokio-runtime-w}(1389715)
                         ├─{tokio-runtime-w}(1389716)
                         ├─{tokio-runtime-w}(1389717)
                         ├─{tokio-runtime-w}(1389718)
                         ├─{tokio-runtime-w}(1389719)
                         ├─{tokio-runtime-w}(1389720)
                         ├─{tokio-runtime-w}(1389721)
                         ├─{tokio-runtime-w}(1389722)
                         ├─{tokio-runtime-w}(1389723)
                         ├─{tokio-runtime-w}(1389724)
                         ├─{tokio-runtime-w}(1389725)
                         ├─{tokio-runtime-w}(1389726)
                         ├─{tokio-runtime-w}(1389727)
                         ├─{tokio-runtime-w}(1389728)
                         ├─{tokio-runtime-w}(1389729)
                         ├─{tokio-runtime-w}(1389730)
                         ├─{tokio-runtime-w}(1389731)
                         ├─{tokio-runtime-w}(1389732)
                         ├─{tokio-runtime-w}(1389733)
                         ├─{tokio-runtime-w}(1389734)
                         ├─{tokio-runtime-w}(1389735)
                         ├─{tokio-runtime-w}(1389736)
                         ├─{tokio-runtime-w}(1389737)
                         ├─{tokio-runtime-w}(1389738)
                         ├─{tokio-runtime-w}(1389739)
                         ├─{tokio-runtime-w}(1389740)
                         ├─{tokio-runtime-w}(1389741)
                         ├─{tokio-runtime-w}(1389742)
                         ├─{tokio-runtime-w}(1389743)
                         ├─{tokio-runtime-w}(1389744)
                         ├─{tokio-runtime-w}(1389745)
                         ├─{tokio-runtime-w}(1389746)
                         ├─{tokio-runtime-w}(1389747)
                         ├─{tokio-runtime-w}(1389748)
                         ├─{tokio-runtime-w}(1389749)
                         ├─{tokio-runtime-w}(1389750)
                         ├─{tokio-runtime-w}(1389751)
                         ├─{tokio-runtime-w}(1389920)
                         ├─{tokio-runtime-w}(1389922)
                         ├─{tokio-runtime-w}(1389925)
                         ├─{tokio-runtime-w}(1389926)
                         ├─{tokio-runtime-w}(1389936)
                         ├─{tokio-runtime-w}(1389938)
                         ├─{tokio-runtime-w}(1389941)
                         └─{tokio-runtime-w}(1389944)
```

There's still 40-ish "solana-validato" unnamed threads running around, I might hunt for some of the higher profile ones and give them useful names as well.

@mvines mvines force-pushed the tr branch 2 times, most recently from 00d8526 to 74c2083 Compare August 19, 2022 01:00
@ryoqun
Copy link
Member

ryoqun commented Aug 19, 2022

just so happy with this. :)

how about prefixing with 0, assuming no more 100 threads for each thread pool, {:02} all over the place should make the after list more pleasant. :)

@mvines
Copy link
Member Author

mvines commented Aug 19, 2022

how about prefixing with 0, assuming no more 100 threads for each thread pool, {:02} all over the place should make the after list more pleasant. :)

Great idea, in the new thread names I already assumed a max of 100 threads for each pool already. Done

@mvines mvines force-pushed the tr branch 2 times, most recently from 6989643 to 5b21358 Compare August 19, 2022 17:10
Tenets:
1. Limit thread names to 15 characters
2. Prefix all Solana-controlled threads with "sol"
3. Use Camel case. It's more character dense than Snake or Kebab case
@mvines mvines merged commit 3f4731b into solana-labs:master Aug 20, 2022
@mvines mvines deleted the tr branch August 20, 2022 14:49
mergify bot added a commit that referenced this pull request Aug 20, 2022
…e usable (backport #27237) (#27280)

Standardize thread names

Tenets:
1. Limit thread names to 15 characters
2. Prefix all Solana-controlled threads with "sol"
3. Use Camel case. It's more character dense than Snake or Kebab case

(cherry picked from commit 3f4731b)

Co-authored-by: Michael Vines <[email protected]>
apfitzge added a commit to apfitzge/agave that referenced this pull request Mar 24, 2023
apfitzge added a commit that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants