Remove redundant and stale comment #27229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Aug 18, 2022
| @@ -44,7 +44,6 @@ impl ExecuteCostTable { | |||
| self.table.len() | |||
| } | |||
|
|
|||
| /// default program cost, set to ComputeBudget::DEFAULT_COMPUTE_UNIT_LIMIT | |||
There was a problem hiding this comment.
maybe, DEFAULT_COMPUTE_UNIT_LIMIT should be DEFAULT_INSTRUCTION_COMPUTE_UNIT_LIMIT. typo at #25229
moreover, i think this comment adds little value, so better off removing it altogether. that's because the fn body is small and the fn name alone is enough while the comment is being redundant.
tao-stones
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see diff comment for details