Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullnode: Merge leader_to_validator/validator_to_leader #2720

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

mvines
Copy link
Member

@mvines mvines commented Feb 11, 2019

This simplifies fullnode rotation implementation by merging the TVU and TPU "rotate" signals. Fullnode doesn't really need to differentiate between them, in all cases it can consult the leader scheduler to determine if it should be leader or not for the next slot.

@mvines mvines requested a review from carllin February 11, 2019 05:23
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #2720 into master will increase coverage by <.1%.
The diff coverage is 86.5%.

@@           Coverage Diff            @@
##           master   #2720     +/-   ##
========================================
+ Coverage    78.4%   78.4%   +<.1%     
========================================
  Files         114     114             
  Lines       18977   18937     -40     
========================================
- Hits        14878   14863     -15     
+ Misses       4099    4074     -25

1 similar comment
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #2720 into master will increase coverage by <.1%.
The diff coverage is 86.5%.

@@           Coverage Diff            @@
##           master   #2720     +/-   ##
========================================
+ Coverage    78.4%   78.4%   +<.1%     
========================================
  Files         114     114             
  Lines       18977   18937     -40     
========================================
- Hits        14878   14863     -15     
+ Misses       4099    4074     -25

@mvines mvines merged commit 095afdf into solana-labs:master Feb 11, 2019
@mvines mvines deleted the merge branch February 11, 2019 16:57
buffalojoec pushed a commit to buffalojoec/solana that referenced this pull request Aug 23, 2024
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants