fix tpu tvu bank race #2707
Merged
fix tpu tvu bank race #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-solana
approved these changes
Feb 8, 2019
|
Can you add a test for this case? |
Codecov Report
@@ Coverage Diff @@
## master #2707 +/- ##
========================================
+ Coverage 77.7% 78.4% +0.7%
========================================
Files 114 114
Lines 18864 18962 +98
========================================
+ Hits 14663 14873 +210
+ Misses 4201 4089 -112 |
mvines
requested changes
Feb 9, 2019
mvines
reviewed
Feb 9, 2019
| @@ -319,6 +320,10 @@ impl Fullnode { | |||
| tick_height, | |||
| ); | |||
|
|
|||
| while self.bank.tick_height() < tick_height { | |||
| sleep(Duration::from_millis(10)); | |||
There was a problem hiding this comment.
There's gotta be a smarter way to do this rather than a semi-random sleep too.
There was a problem hiding this comment.
Sure, but that only further justifies a test. A smarter way can be postponed if we add a good test now.
|
@carllin so this patch rolls into the work I’m doing with stressing fullnodes with super low ticks per slot. Want me to take from here? |
|
@mvines, I'm currently working on a test for this case, so I'll just push that once its ready? |
carllin
force-pushed
the
RotationFix
branch
2 times, most recently
from
ecdd291 to
67b15f3
Compare
mvines
approved these changes
Feb 10, 2019
garious
approved these changes
Feb 10, 2019
andreisilviudragnea
pushed a commit
to andreisilviudragnea/solana
that referenced
this pull request
Aug 23, 2024
…bs#2707) ff cleanup: remove enable_gossip_duplicate_proof_ingestion, it's active everywhere.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Aug 27, 2024
…bs#2707) ff cleanup: remove enable_gossip_duplicate_proof_ingestion, it's active everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The TVU bank could potentially be behind the TPU bank at the time of a leader -> validator transition. In the case of a leader -> leader transition, the TPU bank is then copied from the trailing TVU bank, and broadcast is started up with a last id that is not up to date (causing verification failures) and banking_stage threads are started up with an old bank state.
Summary of Changes
Wait for the TVU bank to catch up to current tick height before performing rotation.
Fixes #