-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement nonblocking version of BlockhashQuery #27040
Conversation
35b68d5
to
6f61f43
Compare
just had to clean up some imports |
6f61f43
to
62a637d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a nit and a request to create a new issue. I've added the v1.11 tag to backport this, that way the token CLI can be fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
62a637d
to
db13a9f
Compare
db13a9f
to
b49fc47
Compare
(in case anyone is looking at this comedic history i have been trying to get ci working but it turns out to just be an interface issue https://buildkite.com/solana-labs/solana/builds/79465) |
(cherry picked from commit b9a5af0)
…7047) Implement nonblocking version of BlockhashQuery (#27040) (cherry picked from commit b9a5af0) Co-authored-by: hana <[email protected]>
Problem
token-cli is in the process of being updated to use the nonblocking rpc client, but we need a nonblocking version of
BlockhashQuery
to support offline signing optionsSummary of Changes
this creates nonblocking versions of
blockhash_query
andnonce_utils
i wasnt able to wrap nonblocking calls in blocking ones, a la
rpc_client
, because these functions accept differentRpcClient
s as parameters. everything innonce_utils
that doesnt have blocking/nonblocking versions was moved into the nonblocking version and reexported by the blocking onei refrained from porting deprecated functions to the new
blockhash_query
and adapted tests to use the new interface. the only substantive change i made is thatbecomes
in an attempt to better reflect its functionality now that the fee calculator is gone. the existing blocking interface is unchanged
closes #27043