-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tpu disable quic in net scripts #27039
Support tpu disable quic in net scripts #27039
Conversation
I think bench-tps client requires option to enable quic as well, otherwise user will need to remember to enable it manually ( Another thing is that it looks like quic will become default soon and option will be tpu-disable-quic quic by default PR. So these options in script will probably require renaming. |
Pull request has been modified.
@lijunwangs , looks like now QUIC is default ( #27194). |
7848ec0
to
213513a
Compare
Yes, it is funny -- I turned it to tpu-disable-quic now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for flopping! It looks like multinode-demo/validator.sh
needs updating as well. Do you mind?
Sure. I will take care of it. I am testing this. I found the cluster would not start up with --tpu-disable-quic turned on. Still debugging. |
It turns out the missing change multinode-demo/validator.sh was causing the issue as the member validator was started with default quic and the bootstrap was started with quic disabled. |
Support tpu disable quic in net scripts
Support tpu disable quic in net scripts
Support passing --tpu-disable-quic in validator launched by net scripts