Bench tps add nonce flag #27030
Merged
Bench tps add nonce flag #27030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
previously approved these changes
Aug 12, 2022
KirillLykov
force-pushed
the
bench_tps_add_nonce_flag
branch
from
dcd56ba to
aa94da2
Compare
mergify
bot
dismissed
joncinque’s stale review
Pull request has been modified.
xiangzhu70
pushed a commit
to xiangzhu70/solana
that referenced
this pull request
Aug 17, 2022
* add durable nonce option * make blockhash thread optional * add nonce test to bench-tps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of chain of PRs to add durable nonce to the bench-tps tool.
This one introduces flag
use_durable_noncewhich allows to turn on this mode manually (cli option in the next PR).It also introduce optional creation of blockhash thread (since for durable nonce we don't need blockhashes).