Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

banking_stage: Remove unused SocketAddr #2703

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Conversation

mvines
Copy link
Member

@mvines mvines commented Feb 8, 2019

The SocketAddr returned by banking_stage::deserialize_transactions() is dead code, remove it

@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label Feb 8, 2019
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #2703 into master will increase coverage by 11%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #2703     +/-   ##
========================================
+ Coverage    66.6%   77.6%    +11%     
========================================
  Files         114     114             
  Lines       22181   19026   -3155     
========================================
- Hits        14777   14774      -3     
+ Misses       7404    4252   -3152

@solana-grimes solana-grimes merged commit 0115a1f into solana-labs:master Feb 8, 2019
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #2703 into master will increase coverage by 11%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #2703     +/-   ##
========================================
+ Coverage    66.6%   77.6%    +11%     
========================================
  Files         114     114             
  Lines       22181   19026   -3155     
========================================
- Hits        14777   14774      -3     
+ Misses       7404    4252   -3152

brooksprumo pushed a commit to brooksprumo/solana that referenced this pull request Aug 23, 2024
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants