Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout to reduce the flakyness of rpc signature receving test #27008

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Increase timeout to reduce the flakyness of rpc signature receving test #27008

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
251a1cb
Increase timeout to reduce the flakyness of rpc signature receving test
xiangzhu70 Aug 8, 2022
5c82875
Minor fmt fix
xiangzhu70 Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion rpc-test/tests/rpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,13 @@ fn test_rpc_subscriptions() {
}

// Wait for all signature subscriptions
let deadline = Instant::now() + Duration::from_secs(15);
/* Set a large 30-sec timeout here because the timing of the above tokio process is
* highly non-deterministic. The test was too flaky at 15-second timeout. Debugging
* show occasional multi-second delay which could come from multiple sources -- other
* tokio tasks, tokio scheduler, OS scheduler. The async nature makes it hard to
* track down the origin of the delay.
*/
let deadline = Instant::now() + Duration::from_secs(30);
while !signature_set.is_empty() {
let timeout = deadline.saturating_duration_since(Instant::now());
match status_receiver.recv_timeout(timeout) {
Expand Down