Fix windows release builds #26986
Merged
Fix windows release builds #26986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you! I tried lots times today 😢 like yihau@a8c196d and yihau@af7aefa but no luck. |
|
oh no. I think set env is clear and good! 👍 |
yihau
approved these changes
Aug 8, 2022
Yeah, it ended up being more annoying than I thought initially 😞 Thanks for all your efforts on it, though! |
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2022
* Don't try to build protobuf-src on windows * Set protoc envar (cherry picked from commit 46b3ece)
mergify bot
added a commit
that referenced
this pull request
Aug 8, 2022
Fix windows release builds (#26986) * Don't try to build protobuf-src on windows * Set protoc envar (cherry picked from commit 46b3ece) Co-authored-by: Tyera Eulberg <[email protected]>
apfitzge
pushed a commit
to apfitzge/agave
that referenced
this pull request
Aug 9, 2022
* Don't try to build protobuf-src on windows * Set protoc envar
xiangzhu70
pushed a commit
to xiangzhu70/solana
that referenced
this pull request
Aug 17, 2022
* Don't try to build protobuf-src on windows * Set protoc envar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#26854 broke windows release builds do to the requirement of a C compiler
Summary of Changes
On windows machines, use installed protoc, instead of trying to build vendored package
Here is an example successful build: https://github.com/solana-labs/solana/runs/7721331802?check_suite_focus=true
from this branch, hacked up to run the CI job on a PR and only build the
solana-storage-protocrateAdding protoc to $PATH instead of setting the envar should also work, if you prefer that approach @yihau .