Unpin tokio for non-rpc crates #26957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incidentally, I confirmed that the stalls are still evident on current tokio (v1.20.1), that a bin with this PR does not exhibit the stalls, and that this PR resolves the issues for downstream users importing solana crates. |
mergify bot
pushed a commit
that referenced
this pull request
Aug 6, 2022
(cherry picked from commit 66919e5) # Conflicts: # banks-server/Cargo.toml # client/Cargo.toml # ledger-tool/Cargo.toml # net-utils/Cargo.toml # storage-bigtable/Cargo.toml # test-validator/Cargo.toml
mergify bot
pushed a commit
that referenced
this pull request
Aug 6, 2022
(cherry picked from commit 66919e5)
mergify bot
added a commit
that referenced
this pull request
Aug 6, 2022
* Unpin tokio for non-rpc crates (#26957) (cherry picked from commit 66919e5) # Conflicts: # banks-server/Cargo.toml # client/Cargo.toml # ledger-tool/Cargo.toml # net-utils/Cargo.toml # storage-bigtable/Cargo.toml # test-validator/Cargo.toml * Fix conflicts Co-authored-by: Tyera Eulberg <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Aug 6, 2022
Unpin tokio for non-rpc crates (#26957) (cherry picked from commit 66919e5) Co-authored-by: Tyera Eulberg <[email protected]>
apfitzge
pushed a commit
to apfitzge/agave
that referenced
this pull request
Aug 9, 2022
xiangzhu70
pushed a commit
to xiangzhu70/solana
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#25028 pinned tokio across all solana crates. However, in actuality only solana-rpc needs to be pinned to avoid the RPC stalls, and the pin is causing problems for downstream users of solana client crates.
Summary of Changes
Unpin tokio everywhere except solana-rpc