Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate file for ImmutableDeserializedPacket type #26951

Conversation

apfitzge
Copy link
Contributor

@apfitzge apfitzge commented Aug 5, 2022

Problem

Transaction schedulers will create and use ImmutableDeserializedPackets outside the context of the UnprocessedPacketBatches. A preliminary step towards #27009

Summary of Changes

Move the ImmutableDeserializedPacket type into its own file, and add a new() constructor.

Fixes #

@apfitzge apfitzge force-pushed the refactor/separate_immutable_deserialized_packet branch 2 times, most recently from 0f39e9e to 3cbe689 Compare August 5, 2022 16:14
@apfitzge apfitzge marked this pull request as ready for review August 8, 2022 13:59
@apfitzge apfitzge requested review from tao-stones and carllin August 8, 2022 13:59
@apfitzge apfitzge self-assigned this Aug 9, 2022
@apfitzge apfitzge force-pushed the refactor/separate_immutable_deserialized_packet branch from 3cbe689 to 650e023 Compare August 9, 2022 16:17
@apfitzge apfitzge force-pushed the refactor/separate_immutable_deserialized_packet branch from 650e023 to be81b5e Compare August 9, 2022 16:30
@apfitzge apfitzge merged commit c03f3b1 into solana-labs:master Aug 10, 2022
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanted to do this for a long time, thanks for taking care of it

xiangzhu70 pushed a commit to xiangzhu70/solana that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants