-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding the runtime transaction account lock limit #26948
Allow overriding the runtime transaction account lock limit #26948
Conversation
adfc633
to
3754075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it work to add a runtime_config: Arc<RuntimeConfig>
field to the Accounts
struct? Feels like currently there's a lot of plumbing to get access to the runtime config param. You did a nice job of making that easy to access from the bank, maybe that'll work for Accounts
too?
The one downside I see is that if the bank changes a value of its runtime config, Accounts would still have the old value (due to COW). Is that a dealbreaker?
It could work and I was hoping to do that originally but there are a lot ways to construct |
…abs#26948) * Add --transaction-account-lock-limit cli arg to test-validator * Allow overriding the tx account lock limit in ProgramTest
* Add --transaction-account-lock-limit cli arg to test-validator * Allow overriding the tx account lock limit in ProgramTest (cherry picked from commit 5618e9f) # Conflicts: # program-test/src/lib.rs # runtime/src/accounts.rs # runtime/src/bank.rs # runtime/src/runtime_config.rs # sdk/src/transaction/sanitized.rs # test-validator/src/lib.rs # validator/src/bin/solana-test-validator.rs
* Add --transaction-account-lock-limit cli arg to test-validator * Allow overriding the tx account lock limit in ProgramTest (cherry picked from commit 5618e9f) # Conflicts: # program-test/src/lib.rs # test-validator/src/lib.rs
Problem
The number of accounts that can be locked by each transaction is currently limited 64 accounts but is not configurable by devs who want to test transactions with more accounts.
Summary of Changes
--transaction-account-lock-limit
cli arg tosolana-test-validator
to override the hardcoded limit of 64Fixes #