Add integration test that transacts against single node rotating on each tick #2693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2693 +/- ##
========================================
Coverage ? 76.6%
========================================
Files ? 113
Lines ? 18405
Branches ? 0
========================================
Hits ? 14108
Misses ? 4297
Partials ? 0 |
|
302 #2750 |
joncinque
added a commit
to joncinque/solana
that referenced
this pull request
Aug 27, 2024
* cli: Use simulated compute units in ping #### Problem The CLI has the ability to simulate transactions before sending to use the correct number of compute units, but `solana ping` is still using the default compute unit limit. #### Summary of changes Simulate once to get the compute unit limit and then re-use the simulated number for every ping. * Refactor per review * Only get compute unit limit if simulation needed, add test
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Aug 27, 2024
* cli: Use simulated compute units in ping #### Problem The CLI has the ability to simulate transactions before sending to use the correct number of compute units, but `solana ping` is still using the default compute unit limit. #### Summary of changes Simulate once to get the compute unit limit and then re-use the simulated number for every ping. * Refactor per review * Only get compute unit limit if simulation needed, add test
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Aug 27, 2024
* cli: Use simulated compute units in ping #### Problem The CLI has the ability to simulate transactions before sending to use the correct number of compute units, but `solana ping` is still using the default compute unit limit. #### Summary of changes Simulate once to get the compute unit limit and then re-use the simulated number for every ping. * Refactor per review * Only get compute unit limit if simulation needed, add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates one way to trigger issue #2675