Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add program account to bpf loader close instruction parser #26926

Merged
merged 1 commit into from
Aug 5, 2022
Merged

add program account to bpf loader close instruction parser #26926

merged 1 commit into from
Aug 5, 2022

Conversation

Xavier59
Copy link
Contributor

@Xavier59 Xavier59 commented Aug 4, 2022

Problem

The close instruction of the bpf_loader program can either be called to close a buffer account or a program data account.
Currently, the bpf loader parser parse the closure of a buffer account properly but is missing an account regarding closure of a program account.
This PR add parsing for the program account.

@mergify mergify bot added the community Community contribution label Aug 4, 2022
@mergify mergify bot requested a review from a team August 4, 2022 19:53
Copy link
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Aug 5, 2022
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Aug 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 5, 2022

automerge label removed due to a CI failure

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Aug 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 5, 2022

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Aug 5, 2022
@jstarry jstarry merged commit a7e72d0 into solana-labs:master Aug 5, 2022
@jstarry
Copy link
Member

jstarry commented Aug 5, 2022

I noticed this case isn't supported yet either if you have the time for it: #26956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants