This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
(Ledger-Tool) Add command --purge-older-slots #26905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
yhchiang-sol
removed
the
stale
steviez
reviewed
Aug 30, 2022
Comment on lines
+2217
to
+2221
| match blockstore.run_purge( | ||
| 0, // from_slot | ||
| ending_slot, | ||
| PurgeType::CompactionFilter, | ||
| ) { |
There was a problem hiding this comment.
The existing purge command can accomplish the same behavior; I believe the following are equivalent:
solana-ledger-tool purge --start_slot 0 --end_slot SLOT ...
solana-ledger-tool purge-older-slots --ending_slot SLOT ...
As such, I don't think this warrants a new subcommand unless there is some subtlety that I'm overlooking
There was a problem hiding this comment.
I didn't notice we already have the purge command. Then I will just improve the comment saying if the starting slot is 0, then all files whose slot range is older than the ending_slot will be deleted immediately.
|
A similar command already exists in ledger-tool. Closing this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current ledger tool does not have a subcommand to purge older slots.
Example use cases of this subcommand include:
Summary of Changes
This PR adds --purge-older-slots to the ledger tool that allows users to
delete slots that are older than or equal to the specified slot.
This PR depends on #26651 and is related to #26790.