Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Io stats v2 #26898

Merged
merged 25 commits into from
Aug 5, 2022
Merged

Io stats v2 #26898

merged 25 commits into from
Aug 5, 2022

Conversation

bw-solana
Copy link
Contributor

@bw-solana bw-solana commented Aug 3, 2022

Problem

Addressing feedback from #26804 . Main problems addressed include being adaptable to multiple versions of /sys/block/*/stat formats and avoiding double counting IO stats in some cases

Summary of Changes

  • Switch to use sysfs (instead of procfs)
  • Add tolerance for older kernel versions of DiskStats

@bw-solana bw-solana mentioned this pull request Aug 3, 2022
@bw-solana bw-solana requested a review from t-nelson August 3, 2022 02:19
@bw-solana bw-solana marked this pull request as ready for review August 3, 2022 02:19
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for jumping on this!

core/src/system_monitor_service.rs Outdated Show resolved Hide resolved
t-nelson
t-nelson previously approved these changes Aug 4, 2022
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna go ahead and r+ this so i can step away for pto.

approved pending additional block device filters and a happy ci

@mergify mergify bot dismissed t-nelson’s stale review August 5, 2022 03:04

Pull request has been modified.

@bw-solana bw-solana added the v1.11 label Aug 5, 2022
@bw-solana bw-solana merged commit 5bc81a6 into solana-labs:master Aug 5, 2022
mergify bot pushed a commit that referenced this pull request Aug 5, 2022
* Use sysfs instead of procfs for disk stats

* Filter map to filter dmcrypt and mdraid volumes

* Unit test cover different kernel formats

(cherry picked from commit 5bc81a6)
@mergify mergify bot mentioned this pull request Aug 5, 2022
mergify bot added a commit that referenced this pull request Aug 5, 2022
Io stats v2 (#26898)

* Use sysfs instead of procfs for disk stats

* Filter map to filter dmcrypt and mdraid volumes

* Unit test cover different kernel formats

(cherry picked from commit 5bc81a6)

Co-authored-by: Brennan Watt <[email protected]>
apfitzge pushed a commit to apfitzge/agave that referenced this pull request Aug 9, 2022
* Use sysfs instead of procfs for disk stats

* Filter map to filter dmcrypt and mdraid volumes

* Unit test cover different kernel formats
xiangzhu70 pushed a commit to xiangzhu70/solana that referenced this pull request Aug 17, 2022
* Use sysfs instead of procfs for disk stats

* Filter map to filter dmcrypt and mdraid volumes

* Unit test cover different kernel formats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants