Refactor QUIC new connection handler function #26855
Conversation
pgarg66
force-pushed
the
cleanup-quic-streamer
branch
from
0103c74 to
06b6e0f
Compare
|
Generally, it is a good idea to simplify original code by extracting functions. |
pgarg66
force-pushed
the
cleanup-quic-streamer
branch
from
06b6e0f to
6366cde
Compare
@KirillLykov, thanks for reviewing this PR. I have tried to functionally split the PR into three commits. Hopefully it makes it easier to view the code diff. The first two commits contain the most relevant diffs. |
|
|
||
| let remote_addr = connection.remote_address(); | ||
| let remote_addr = new_connection.connection.remote_address(); | ||
| let mut remote_pubkey = None; | ||
|
|
||
| let table_and_stake = { |
There was a problem hiding this comment.
A note: looks like table_and_stake is not used and will be removed in the next commits
| @@ -217,6 +217,94 @@ impl NewConnectionHandlerParams { | |||
| } | |||
| } | |||
|
|
|||
| fn handle_and_cache_new_connection( | |||
There was a problem hiding this comment.
Note: this commit just moves functions a bit up in the code, no changes
* Refactor QUIC new connection handler function * cleanup setup_connection * more cleanup
* Refactor QUIC new connection handler function * cleanup setup_connection * more cleanup
* Refactor QUIC new connection handler function * cleanup setup_connection * more cleanup
Problem
setup_connectionfunction has gotten convoluted over time, and could use a refactor.Summary of Changes
Refactored the function into smaller blocks and also improve the code reuse.
Fixes #