add withdraw durable nonce #26829
Merged
add withdraw durable nonce #26829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirillLykov
force-pushed
the
benchRefactorCreate_fu7
branch
from
0c783c9 to
05ff1b6
Compare
KirillLykov
force-pushed
the
benchRefactorCreate_fu7
branch
from
05ff1b6 to
cca2bec
Compare
KirillLykov
commented
Jul 29, 2022
| @@ -109,17 +109,35 @@ pub fn generate_durable_nonce_accounts<T: 'static + BenchTpsClient + Send + Sync | |||
| let (mut nonce_keypairs, _extra) = generate_keypairs(seed_keypair, count as u64); | |||
| nonce_keypairs.truncate(count); | |||
|
|
|||
| let to_fund: Vec<(&Keypair, &Keypair)> = authority_keypairs | |||
| let to_fund: Vec<NonceCreateSigners> = authority_keypairs | |||
There was a problem hiding this comment.
I replace pair to struct in order to have two different types for Withdraw and Create accounts. It is required because for Create I need two signatures and for Withdraw only one (Sliceable::to_slice method returns array of signing Keypairs).
joncinque
previously approved these changes
Jul 29, 2022
bench-tps/src/send_batch.rs
Outdated
| &authority.pubkey(), | ||
| nonce_rent, | ||
| ); | ||
| struct NonceWithdrawSigners<'a>(&'a Keypair, &'a Keypair); |
There was a problem hiding this comment.
nit: It would be clearer for the second parameter to be a Pubkey since it's not signing, but I think that'll make things more complicated in the implementation, like (&'a Keypair, Pubkey), which is probably worse. I imagine you already considered this tradeoff 😅
There was a problem hiding this comment.
Actually this is really good point! And it happens that it is quite easy to implement
Before &Keypair was passed although it is not necessary because nonce doesn't sign withdraw account transactions anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adds function which withdraws durable nonce accounts.
This is part of the series of PRs adding durable nonce accounts to bench-tps: #25759
Summary of Changes