Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): bump protoc to v21.4 #26827

Closed
wants to merge 1 commit into from
Closed

Conversation

riptl
Copy link
Contributor

@riptl riptl commented Jul 28, 2022

Problem

The Protobuf SDK used in ci/docker-rust hasn't been upgraded since May 2019: https://github.com/protocolbuffers/protobuf/releases/v3.8.0

Recent releases of Protobuf ship major new features, such as the optional qualifier in proto3.

The most recent version is v21.4: https://github.com/protocolbuffers/protobuf/releases

Summary of Changes

  • Changes Protobuf repo from google/protobuf (deprecated) to protocolbuffers/protobuf.
  • Upgrades CI runner to Protobuf v21.4

Fixes #

@mergify mergify bot added the community Community contribution label Jul 28, 2022
@mergify mergify bot requested a review from a team July 28, 2022 07:27
@riptl riptl changed the title ci/docker-rust: bump protoc to v21.4 chore(ci): bump protoc to v21.4 Jul 28, 2022
@CriesofCarrots
Copy link
Contributor

Sorry for the delay on this, but I'm considering adding protobuf-src here: #26854, in which case we can probably remove the docker dependency entirely.

@stale
Copy link

stale bot commented Aug 13, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Aug 13, 2022
@CriesofCarrots CriesofCarrots removed the stale [bot only] Added to stale content; results in auto-close after a week. label Aug 13, 2022
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Dec 29, 2022
@github-actions github-actions bot closed this Jan 6, 2023
@riptl riptl deleted the protoc-v21.4 branch January 22, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants