Add explicit comment about get_stake_account to StakeInstruction enum #26824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
stake-ix-docs
branch
from
1033ed4 to
f747344
Compare
mergify
bot
dismissed
brooksprumo’s stale review
Pull request has been modified.
|
Docs-only change, been through doctest CI already, merging early |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As per #26294 (comment), it's easy to miss the check needed to preserve consensus when adding a new feature-gated stake instruction while
add_get_minimum_delegation_instruction_to_stake_programis not yet active.Summary of Changes
Add explicit comment describing pattern to follow