This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
More fullnode grooming #2681
Merged
More fullnode grooming #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2681 +/- ##
========================================
+ Coverage 76.7% 76.7% +<.1%
========================================
Files 114 114
Lines 18583 18581 -2
========================================
Hits 14254 14254
+ Misses 4329 4327 -2 |
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Aug 27, 2024
…lana-labs#2666) (solana-labs#2681) * customizes override logic for gossip ContactInfo (solana-labs#2579) If there are two running instances of the same node, we want the ContactInfo with more recent start time to be propagated through gossip regardless of wallclocks. The commit adds custom override logic for ContactInfo to first compare by outset timestamp. * updates ContactInfo.outset when hot-swapping identity (solana-labs#2613) When hot-swapping identity, ContactInfo.outset should be updated so that the new ContactInfo overrides older node with the same pubkey. * patches bug causing false duplicate nodes error (solana-labs#2666) The bootstrap code during the validator start pushes a contact-info with more recent timestamp to gossip. If the node is staked the contact-info lingers in gossip causing false duplicate node instances when the fully initialized node joins gossip later on. The commit refreshes the timestamp on contact-info so that it overrides the one pushed by bootstrap and avoid false duplicates error. --------- Co-authored-by: behzad nouri <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅Remove more unnecessary
puband dead code✅Remove unnecessary imports
✅Refactor confusing role_notifiers tuple
✅Shuffle types to tvu.rs/tpu.rs so that less files need to import
fullnode(fullnode ought to be at the top of the dogpile, nobody should import it)