Compute maximum parallel QUIC streams using client stake #26802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
force-pushed
the
client-staked-stream
branch
from
546eefa to
92f7e5d
Compare
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 10, 2022
…#26802) * Compute maximum parallel QUIC streams using client stake * clippy fixes * Add unit test
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 13, 2022
…#26802) * Compute maximum parallel QUIC streams using client stake * clippy fixes * Add unit test
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 13, 2022
…#26802) * Compute maximum parallel QUIC streams using client stake * clippy fixes * Add unit test
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Sep 13, 2022
…#26802) * Compute maximum parallel QUIC streams using client stake * clippy fixes * Add unit test
lijunwangs
pushed a commit
that referenced
this pull request
Sep 14, 2022
* Compute maximum parallel QUIC streams using client stake * clippy fixes * Add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
QUIC client is always chunking transactions with
QUIC_MAX_UNSTAKED_CONCURRENT_STREAMSas maximum number of chunks. This limits staked clients (e.g. nodes forwarding transactions) on how fast the transactions can be sent.The following graph is from master branch.
Summary of Changes
This PR updates client to use the same logic as QUIC streamer to calculate how many transactions can be sent in parallel. The calculation uses client's stake and total stake across cluster. The information is already available on a full validator node.
The following graph is with this PR
Fixes #