Add feature gate to use default units per instruction for fee calculation #26786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackcmay
approved these changes
Jul 26, 2022
tao-stones
added
the
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
jstarry
added
the
feature-gate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When bank calculates transaction fee, it's hardcoded to not to use default units per instruction, which is a feature already enabled in mainnet-beta. It should use default units.
Summary of Changes
Add feature to pass
false(current behavior) when feature is not enabled, andtrue(desired behavior) when feature is enabled.Feature Gate Issue: #26785