Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (web3.js) clear the idle timer whenever the websocket closes #26734

Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix: (web3.js) clear the idle timer whenever the websocket closes #26734

merged 1 commit into from
Jul 25, 2022

Conversation

steveluscher
Copy link
Contributor

@steveluscher steveluscher commented Jul 22, 2022

Problem

If the websocket closes while there's an active idle timer, the connection can enter a corrupt state as described in solana-labs/solana-web3.js#1106.

Summary of Changes

  • Clear the idle timer whenever the websocket connection drops.

Fixes #26665.

@steveluscher steveluscher changed the title fix: clear the idle timer whenever the websocket closes fix: (web3.js) clear the idle timer whenever the websocket closes Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #26734 (c23f9de) into master (ce337e0) will increase coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   solana-labs/solana#26734   +/-   ##
=======================================
  Coverage    77.4%    77.5%           
=======================================
  Files          42       42           
  Lines        2462     2465    +3     
  Branches      351      352    +1     
=======================================
+ Hits         1908     1911    +3     
  Misses        424      424           
  Partials      130      130           

@steveluscher steveluscher merged commit f4100f6 into solana-labs:master Jul 25, 2022
@steveluscher steveluscher deleted the cancel-idle-timer-on-close-of-websocket branch July 25, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop in web3.js subscription handling
1 participant