feat(web3.js): add support for get stake minimum delegation #26682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26682 +/- ##
===========================================
- Coverage 81.9% 77.4% -4.5%
===========================================
Files 631 42 -589
Lines 174252 2459 -171793
Branches 0 353 +353
===========================================
- Hits 142728 1905 -140823
+ Misses 31524 422 -31102
- Partials 0 132 +132 |
atharmohammad
force-pushed
the
issue#26564
branch
4 times, most recently
from
ef8d7bf to
8602516
Compare
atharmohammad
force-pushed
the
issue#26564
branch
from
8602516 to
dcd6ab5
Compare
mergify
bot
dismissed
steveluscher’s stale review
Pull request has been modified.
steveluscher
previously requested changes
Jul 21, 2022
web3.js/src/connection.ts
Outdated
| * get the stake minimum delegation | ||
| */ | ||
| async getStakeMinimumDelegation( | ||
| commitment?: Commitment, |
There was a problem hiding this comment.
Close! I really did mean to take a config object here, even if for now it only contains a single property. This makes the method call future proof; if we need to add another property then we have a place to do it. There are other examples in this file of calls that take a config. Check it out!
Optional config, optional commitment property inside.
atharmohammad
force-pushed
the
issue#26564
branch
from
dcd6ab5 to
a2662bf
Compare
mergify
bot
dismissed
steveluscher’s stale review
Pull request has been modified.
atharmohammad
force-pushed
the
issue#26564
branch
from
a2662bf to
9ae40f6
Compare
This was referenced Aug 26, 2022
This was referenced Sep 10, 2022
This was referenced Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds --
1). support for
getStakeMinimumDelegationto web3.js with a test.fixes #26564