move hash stat to correct level for ahv to work #26649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
reviewed
Jul 18, 2022
| @@ -15,7 +15,6 @@ pub struct ActiveStats { | |||
| pub enum ActiveStatItem { | |||
| Clean, | |||
| Shrink, | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Looks unrelated to this PR. Was this intentional?
There was a problem hiding this comment.
yes. this was left over and cleanup that I found and threw in.
| @@ -6596,7 +6596,6 @@ impl AccountsDb { | |||
| slot: Slot, | |||
| config: &CalcAccountsHashConfig<'_>, | |||
| ) -> Result<(Hash, u64), BankHashVerificationError> { | |||
| let _guard = self.active_stats.activate(ActiveStatItem::Hash); | |||
There was a problem hiding this comment.
This placement should still track all calls for hashing, yes? Is it that you don't want to track when calculating the accounts hash using the index?
There was a problem hiding this comment.
we don't care about using the index. that code path only exists for debugging.
brooksprumo
approved these changes
Jul 18, 2022
Lcchy
pushed a commit
to Bonfida/solana
that referenced
this pull request
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
these stats are not being updated correctly since the move to accounts_hash_verifier
Summary of Changes
Fixes #