Patch crossbeam-epoch to avoid overhead #26555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Jul 11, 2022
ryoqun
force-pushed
the
reduced-collection-frequency
branch
from
650666b to
597809a
Compare
ryoqun
commented
Jul 12, 2022
| @@ -968,8 +968,7 @@ dependencies = [ | |||
| [[package]] | |||
| name = "crossbeam-epoch" | |||
| version = "0.9.5" | |||
There was a problem hiding this comment.
$ cat /home/ryoqun/.cargo/registry/src/github.com-1ecc6299db9ec823/crossbeam-epoch-0.9.5/.cargo_vcs_info.json
{
"git": {
"sha1": "6d4cdd4daf9a897deef6cde9569f2fbf12c29bc5"
}
}
...
ryoqun@ubuqun:~/work/crossbeam/crossbeam-epoch$ git diff --patch-with-stat --no-index . /home/ryoqun/.cargo/registry/src/github.com-1ecc6299db9ec823/crossbeam-epoch-0.9.5/
...
There was a problem hiding this comment.
you can verify that there is barely minimum modifications by comparing this published commit rev with the parent commit rev of my patch commit: https://github.com/solana-labs/solana/pull/26555/files#r918444566
ryoqun
commented
Jul 12, 2022
Cargo.toml
Outdated
| @@ -91,5 +91,6 @@ exclude = [ | |||
| "programs/bpf", | |||
| ] | |||
|
|
|||
| # This prevents a Travis CI error when building for Windows. | |||
| resolver = "2" | |||
| # for details, see https://github.com/ryoqun/crossbeam/commit/fd279d707025f0e60951e429bf778b4813d1b6bf | |||
There was a problem hiding this comment.
for convenience: anza-xyz/crossbeam@fd279d7
|
I've run a validator on MNB for multiple days w/o any issues (w/ this change on top of v1.10.32) |
bw-solana
previously approved these changes
Jul 26, 2022
ryoqun
force-pushed
the
reduced-collection-frequency
branch
from
b2fb4e5 to
58aa506
Compare
|
a few hygiene are done:
|
ryoqun
force-pushed
the
reduced-collection-frequency
branch
from
58aa506 to
6f6636d
Compare
bw-solana
previously approved these changes
Aug 8, 2022
ryoqun
force-pushed
the
reduced-collection-frequency
branch
from
96322d7 to
17369f3
Compare
xiangzhu70
pushed a commit
to xiangzhu70/solana
that referenced
this pull request
Aug 17, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
(cherry picked from commit ad3e10f)
willhickey
pushed a commit
that referenced
this pull request
Aug 17, 2022
(cherry picked from commit ad3e10f)
mergify bot
added a commit
that referenced
this pull request
Aug 17, 2022
Patch crossbeam-epoch to avoid overhead (#26555) (cherry picked from commit ad3e10f) Co-authored-by: Ryo Onodera <[email protected]>
ryoqun
added a commit
that referenced
this pull request
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fixes #22603
our rayon usage might be peculiar enough to warrant patching...:
crossbeam-rs/crossbeam#852 (comment)
Summary of Changes
Fixes #