Fix sol_get_processed_sibling_instruction on 32-bit hosts #26522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riptl
force-pushed
the
fix-processed-sibling-instruction
branch
from
5504dcf to
5de4f4b
Compare
Lichtso
previously approved these changes
Jul 11, 2022
riptl
force-pushed
the
fix-processed-sibling-instruction
branch
from
5de4f4b to
c41462e
Compare
jackcmay
approved these changes
Jul 27, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 5, 2022
(cherry picked from commit a9a3c62)
mergify bot
added a commit
that referenced
this pull request
Aug 5, 2022
…26522) (#26958) Fix sol_get_processed_sibling_instruction on 32-bit hosts (#26522) (cherry picked from commit a9a3c62) Co-authored-by: Richard Patel <[email protected]>
apfitzge
pushed a commit
to apfitzge/agave
that referenced
this pull request
Aug 9, 2022
xiangzhu70
pushed a commit
to xiangzhu70/solana
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Syscall
sol_get_processed_sibling_instructionwrites structProcessedSiblingInstructionto VM memory. This struct containsusizeparameters, which have different lengths across different architectures. The de-facto hostusizeis 64-bit on Solana, of course.32-bit hosts such as
wasm32would write 32-bit values, causing memory corruption in the VM.Summary of Changes
Changes
usizeparameters inProcessedSiblingInstructiontou64. This is a no-op on 64-bit host architectures.Fixes #