-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Lookup Table Program Instruction Web3 Bindings #26469
Address Lookup Table Program Instruction Web3 Bindings #26469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, thanks for adding this! Beyond my review comments, can you also add tests to confirm this works end to end? Tests use a local validator and can be run with npm run test:live-with-test-validator
. You can use system-program.test.ts
as a template for how these tests should be written.
74843e6
to
8c29960
Compare
We're working on the tests. |
Fixes and tests look great! Please take a look at antematter#1 and merge if it looks good to you. Once that's resolved we can get this shipped |
fix: alloc encoding buffer properly for seq layouts
Feel free to ignore the commit-lint failure but can you fix the doc failure here: https://github.com/solana-labs/solana/runs/7326663456?check_suite_focus=true |
Thanks again! |
Happy to help! Let us know how we can contribute more, we're eager to use the lookup tables. |
…ns (solana-labs#26469) * feat: added web3 bindings for Address Lookup Table Program * fix: refactoring + addresses PR comments * fix: typos fixed and minor refactoring * add lookup table instruction decoding support + fixes recent slot serialization bug * export lookup table program * linting * fix: type annotations * add tests cases for address lookup table program * fix: alloc encoding buffer properly for seq layouts * fix: typedoc issue Co-authored-by: Antematter <[email protected]> Co-authored-by: Muhammad Saad <[email protected]> Co-authored-by: Justin Starry <[email protected]>
Problem
Web3 TypeScript bindings were missing for Address Lookup Table Program. This PR adds the appropriate client bindings to generate instructions needed to interact with the said program.
Summary of Changes
Fixes #3294 on Solana Program Library
Disclaimer
Proudly contributed by the worthless pixels, an NFT project full of die hard solana maxis. Wen arb bot? @worthlesspixels on Twitter.