-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add design for the forking bank #2646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeyakovenko
changed the title
fork design book chapter
fork checkpointing design book chapter
Feb 4, 2019
aeyakovenko
changed the title
fork checkpointing design book chapter
fork checkpointing book chapter
Feb 4, 2019
aeyakovenko
changed the title
fork checkpointing book chapter
Add a chapter covering the fork checkpointing implementation
Feb 4, 2019
garious
reviewed
Feb 4, 2019
rob-solana
reviewed
Feb 4, 2019
The problem description for this PR doesn't describe a problem. |
s/live_bank_state/active_fork |
s/BankState/BankFork |
s/active chain/active fork |
garious
force-pushed
the
forking_design
branch
from
February 6, 2019 23:45
bd84889
to
f78ac65
Compare
garious
force-pushed
the
forking_design
branch
from
February 6, 2019 23:49
f78ac65
to
b85b9e0
Compare
@rob-solana, can you give this another pass? I get the feeling I'm confusing forks and deltas. |
garious
changed the title
Add a chapter covering the fork checkpointing implementation
Add design for the forking bank
Feb 7, 2019
This would be a fine document to introduce the term delta, but it looks like the content flows just fine without it.
garious
approved these changes
Feb 7, 2019
@rob-solana, this look good to you? |
bw-solana
pushed a commit
to bw-solana/solana
that referenced
this pull request
Aug 22, 2024
…#2646) We need the receiver to hold just one message so there is no need to have an unbounded channel.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Aug 27, 2024
…#2646) We need the receiver to hold just one message so there is no need to have an unbounded channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Each block is a voting point. Each vote can be rolled back. The Bank needs a way to manage the rollback points.
Summary of Changes
Architecture doc for the fork checkpoint design.
Fixes # (pr #2640)