Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design for the forking bank #2646

Merged
merged 7 commits into from
Feb 7, 2019

Conversation

aeyakovenko
Copy link
Member

@aeyakovenko aeyakovenko commented Feb 2, 2019

Problem

Each block is a voting point. Each vote can be rolled back. The Bank needs a way to manage the rollback points.

Summary of Changes

Architecture doc for the fork checkpoint design.

Fixes # (pr #2640)

@aeyakovenko aeyakovenko changed the title fork design book fork design book chapter Feb 4, 2019
@aeyakovenko aeyakovenko changed the title fork design book chapter fork checkpointing design book chapter Feb 4, 2019
@aeyakovenko aeyakovenko changed the title fork checkpointing design book chapter fork checkpointing book chapter Feb 4, 2019
@aeyakovenko aeyakovenko changed the title fork checkpointing book chapter Add a chapter covering the fork checkpointing implementation Feb 4, 2019
book/src/fork-checkpoints.md Outdated Show resolved Hide resolved
book/src/fork-checkpoints.md Outdated Show resolved Hide resolved
book/src/fork-checkpoints.md Outdated Show resolved Hide resolved
book/src/fork-checkpoints.md Outdated Show resolved Hide resolved
book/src/fork-checkpoints.md Outdated Show resolved Hide resolved
@garious
Copy link
Contributor

garious commented Feb 4, 2019

The problem description for this PR doesn't describe a problem.

@aeyakovenko aeyakovenko requested a review from sakridge February 4, 2019 22:26
@aeyakovenko
Copy link
Member Author

s/live_bank_state/active_fork
s/BankCheckpoint/BankDelta

@aeyakovenko
Copy link
Member Author

s/BankState/BankFork

@aeyakovenko
Copy link
Member Author

s/active chain/active fork

@garious
Copy link
Contributor

garious commented Feb 7, 2019

@rob-solana, can you give this another pass? I get the feeling I'm confusing forks and deltas.

@garious garious changed the title Add a chapter covering the fork checkpointing implementation Add design for the forking bank Feb 7, 2019
This would be a fine document to introduce the term delta, but
it looks like the content flows just fine without it.
@garious
Copy link
Contributor

garious commented Feb 7, 2019

@rob-solana, this look good to you?

@garious garious merged commit c82ffaa into solana-labs:master Feb 7, 2019
bw-solana pushed a commit to bw-solana/solana that referenced this pull request Aug 22, 2024
…#2646)

We need the receiver to hold just one message so there is no need
to have an unbounded channel.
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Aug 27, 2024
…#2646)

We need the receiver to hold just one message so there is no need
to have an unbounded channel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants